Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compliance Matrix Validation for rel1.0.0 - Baggage , Resource #718

Closed
7 tasks done
lalitb opened this issue May 3, 2021 · 4 comments
Closed
7 tasks done

Compliance Matrix Validation for rel1.0.0 - Baggage , Resource #718

lalitb opened this issue May 3, 2021 · 4 comments
Assignees
Labels
release:required-for-ga To be resolved before GA release spec-compliance Not compliant to OpenTelemetry specs
Milestone

Comments

@lalitb
Copy link
Member

lalitb commented May 3, 2021

This ticket is to validate the below attributes of the Spec Compliance Matrix for Rel 1.0.0. While validation, if there is any ticket created for non-compliance, mention that next to the non-compliant point below in the description.

Link:
Baggage: https://github.com/open-telemetry/opentelemetry-specification/blob/v1.0.0/spec-compliance-matrix.md#baggage
Resource: https://github.com/open-telemetry/opentelemetry-specification/blob/v1.0.0/spec-compliance-matrix.md#resource

Baggage:

  • Basic Support
  • Use official header name baggage

Resource:

  • Create from Attributes
  • Create empty
  • Merge (v2)
  • Retrieve attributes
  • Default value for service.name
@lalitb lalitb added release:required-for-ga To be resolved before GA release spec-compliance Not compliant to OpenTelemetry specs labels May 3, 2021
@lalitb lalitb added this to the 1.0.0-rc.1 milestone May 3, 2021
@lalitb lalitb self-assigned this May 5, 2021
@maxgolov
Copy link
Contributor

One issue we need to fix for Resource API : #733

@lalitb
Copy link
Member Author

lalitb commented Jun 3, 2021

Baggage

Basic Support :

https://github.com/open-telemetry/opentelemetry-cpp/blob/v0.7.0/api/include/opentelemetry/baggage/baggage.h

Use official header name baggage

static const nostd::string_view kBaggageHeader = "baggage";

@lalitb
Copy link
Member Author

lalitb commented Jun 3, 2021

Resource

Create from Attributes

Resource Resource::Create(const ResourceAttributes &attributes)

Create empty

Resource &Resource::GetEmpty()

Merge (v2)

Resource Resource::Merge(const Resource &other) noexcept

Retrieve attributes

const ResourceAttributes &Resource::GetAttributes() const noexcept

Default value for service.name

std::string default_service_name = "unknown_service";

@lalitb
Copy link
Member Author

lalitb commented Jun 3, 2021

Validated all the specs compliance points.

@lalitb lalitb closed this as completed Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:required-for-ga To be resolved before GA release spec-compliance Not compliant to OpenTelemetry specs
Projects
None yet
Development

No branches or pull requests

2 participants