Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Boost license implications #68

Closed
maxgolov opened this issue Apr 27, 2020 · 4 comments
Closed

Investigate Boost license implications #68

maxgolov opened this issue Apr 27, 2020 · 4 comments
Assignees
Labels
priority:p2 Issues that are not blocking

Comments

@maxgolov
Copy link
Contributor

A portion of nostd::variant currently requires a Boost-licensed header.
This may be an issue for some commercial products.

Two alternatives to consider:

  • research if we can get that portion code contributed under Open Telemetry (Apache-style) license. That way we still satisfy the ABI stability guarantees.

  • the other alternative is to compile with std Ability to use Standard Library instead of opentelemetry nostd classes #67 . That approach means that commercial products building from source with standard library cannot safely interop with other prebuilt Open Telemetry modules.

@maxgolov
Copy link
Contributor Author

I'll try to remove MPark variant and replace by Abseil Variant absl::variant. There is no other code in this repo that requires Boost License.

@maxgolov maxgolov self-assigned this Dec 10, 2020
@maxgolov maxgolov added the priority:p2 Issues that are not blocking label Dec 10, 2020
@maxgolov
Copy link
Contributor Author

I would propose we totally remove MPark variant - replacing it with a copy of implementation borrowed from absl::variant. I need this anyways to start supporting Visual Studio 2015 #314 ... Thus, removing MPark variant we will get rid of the Boost licensing issue.

@maxgolov
Copy link
Contributor Author

maxgolov commented Apr 5, 2021

Sorry for inactivity on it -- I'll switch to absl::variant #572 thus removing the need for Boost License. ETA: April 2021

@maxgolov
Copy link
Contributor Author

Closing as Duplicate of #572 - switching to Abseil Variant would allow us to remove Boost -Licensed code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p2 Issues that are not blocking
Projects
None yet
Development

No branches or pull requests

1 participant