-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gRPC Instrumentation #530
Comments
I see a B3Propagator was commited today , Is this the recomended format for trace propagation? Or should the W3C format be used ? |
From instrumentation library prospective, it can be assumed that the right type of propagator would be already set ( refer : https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/context/api-propagators.md#global-propagators ). While it is not yet implemented for C++ ( #540), there would be api to |
Is this still open/available? Would I be able to pick this up? |
Depends on your cloud service provider. w3c TraceContext is the default endorsed and recommended: B3 is |
@bryanuribe - in terms of gRPC w3c context propagation, I think @Hablapatabla is already working in this direction: |
@alolita - let's discuss this item during C++ SIG call. I guess what we need to achieve:
I can help with W3C Trace Context validation, early customer feedback, etc. I have customers lined up for that already. |
@bryanuribe - would you be able to join the next C++ SIG meeting? It would be immensely helpful if you can help us with B3 context propagator validation, and maybe covering Amazon-specific context propagator in contrib repo. Slack channel where we can discuss it: |
@maxgolov Yes, I will be at the next SIG meeting. Awesome, I will reach out to you over slack |
@maxgolov will join in for the next SIG meeting - let's discuss. |
#729 closes this |
Add support for gRPC C++ client and server api calls instrumentation either using
The text was updated successfully, but these errors were encountered: