-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration tests for single-core machines #360
Comments
I think just using --cpus=1 on Linux is probably fine for now. I"ll add that in a PR after the updated spin-lock (#415) goes through |
This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs. |
This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs. |
This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs. |
Is your feature request related to a problem?
It's possible that the C++ API is used on single-core machines. If we don't test our code on single core, it's possible we use threading primitives that require multi-core to make progress, e.g spin-locks.
Describe the solution you'd like
We should at a minimum KNOW if we support single-core machines via running integration tests against them. It could be we explicitly decide not to support single-core usage, but we should at least know the status.
Describe alternatives you've considered
Have not considered alternatives.
Additional context
N/A
The text was updated successfully, but these errors were encountered: