Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests for single-core machines #360

Open
jsuereth opened this issue Oct 12, 2020 · 5 comments
Open

Add integration tests for single-core machines #360

jsuereth opened this issue Oct 12, 2020 · 5 comments
Labels
do-not-stale priority:p2 Issues that are not blocking

Comments

@jsuereth
Copy link
Contributor

Is your feature request related to a problem?
It's possible that the C++ API is used on single-core machines. If we don't test our code on single core, it's possible we use threading primitives that require multi-core to make progress, e.g spin-locks.

Describe the solution you'd like
We should at a minimum KNOW if we support single-core machines via running integration tests against them. It could be we explicitly decide not to support single-core usage, but we should at least know the status.

Describe alternatives you've considered
Have not considered alternatives.

Additional context
N/A

@maxgolov
Copy link
Contributor

maxgolov commented Dec 1, 2020

@jsuereth - is this something we can run on GitHub Action - Linux image, with --cpus=1 option? This may cover Linux, but not Windows nor Mac.

@jsuereth
Copy link
Contributor Author

jsuereth commented Dec 3, 2020

I think just using --cpus=1 on Linux is probably fine for now. I"ll add that in a PR after the updated spin-lock (#415) goes through

@lalitb lalitb added the priority:p2 Issues that are not blocking label Dec 16, 2020
@github-actions
Copy link

This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs.

@github-actions github-actions bot added the Stale label Nov 24, 2021
@lalitb lalitb removed the Stale label Nov 24, 2021
@github-actions
Copy link

This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs.

@github-actions
Copy link

This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs.

@github-actions github-actions bot added the Stale label Mar 26, 2022
@lalitb lalitb removed the Stale label Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-stale priority:p2 Issues that are not blocking
Projects
None yet
Development

No branches or pull requests

3 participants