Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXPORTER] Allow construct OTLP gRPC exporters from existing grpc::Channel #3010

Open
owent opened this issue Jul 23, 2024 · 1 comment · May be fixed by #3041
Open

[EXPORTER] Allow construct OTLP gRPC exporters from existing grpc::Channel #3010

owent opened this issue Jul 23, 2024 · 1 comment · May be fixed by #3041
Assignees
Labels
Stale triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@owent
Copy link
Member

owent commented Jul 23, 2024

Is your feature request related to a problem?
When we have multiple providers and OTLP gRPC exporters in our application, gRPC will create a lot of threads for each grpc::Channel, especially in a server machine with a lot CPUs.

Describe the solution you'd like
Exporting OtlpGrpcClient for users and allow construct all OTLP exporters with shared grpc::Channel.

Additional context

[user00@VM-245-181-centos ~/tgf-server/g-4]$ cat /proc/cpuinfo | grep processor | tail -n 1 | awk '{print $NF+1}'
132
[user00@VM-245-181-centos ~/tgf-server/g-4]$ ps huH -p 107277 | wc
    276    6072   72588

In a system with 132 CPUs, it allocate 250+ threads in just one process with about 4 OTLP gRPC exporters.
We have 600+ processes in ours system and the load average is so high.

Can we add a new gRPC options to allow to build OTLP gRPC exporters from existed gRPC Channel?
I can take this if this feature is accepted.

@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 23, 2024
@marcalff marcalff added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 23, 2024
@marcalff marcalff changed the title Allow construct OTLP gRPC exporters from existed grpc::Channel [EXPORTER] Allow construct OTLP gRPC exporters from existing grpc::Channel Jul 23, 2024
@owent owent linked a pull request Aug 30, 2024 that will close this issue
3 tasks
Copy link

This issue was marked as stale due to lack of activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants