Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Cloud Trace old propagation headers #2683

Closed
bambuchaAdm opened this issue May 24, 2024 · 1 comment
Closed

Support for Cloud Trace old propagation headers #2683

bambuchaAdm opened this issue May 24, 2024 · 1 comment
Assignees
Labels
triage/duplicate Indicates an issue is a duplicate of other open issue.

Comments

@bambuchaAdm
Copy link

Is your feature request related to a problem?
GCP as platform use Cloud Trace. Currently most of service are able to consume correctly WC3 propagation headers. Notable exception of this is Load Balancer that supports only old header X-Cloud-Trace-Context and looks like it would not change in very fast according to reported issue

This comes out when we enable opentelemetry support for ingress-nginx and integration with LB request logs breaks.
Ingress open-telemetry support only WC3 and B3 headers as they are implemented here and because of it breaks propagation of trace over this request. We would like to add support of Cloud Trace legacy headers to ingress nginx specially for request that are made via GCLB and it would be nice that Importer would comes from same way as B3 and WC3 headers.

Describe the solution you'd like
Implementation of Importer/Exporter in API of legacy Cloud Trace propagation headers. Of course named as deprecated but have global ability to "consume" those traces in uniform way.

Describe alternatives you've considered
If not in main API to not propagate legacy solution in new SDK put that implementation to 3rd party repository.

Additional context
Specification of X-Cloud-Trace-Context header: https://cloud.google.com/trace/docs/trace-context#legacy-http-header

I can try prepare pull request for those changes but asking first is usual preferred

@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 24, 2024
@marcalff
Copy link
Member

Official (W3C trace context) propagators are implemented in the opentelemetry-cpp repository.

Vendors opentelemetry propagators should be placed in the opentelemetry-cpp-contrib repository.

Closing, duplicate with:

@marcalff marcalff self-assigned this May 29, 2024
@marcalff marcalff added triage/duplicate Indicates an issue is a duplicate of other open issue. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/duplicate Indicates an issue is a duplicate of other open issue.
Projects
None yet
Development

No branches or pull requests

2 participants