Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main does not compile on debian stable #2634

Closed
t-b opened this issue Apr 11, 2024 · 2 comments
Closed

main does not compile on debian stable #2634

t-b opened this issue Apr 11, 2024 · 2 comments
Assignees
Labels
bug Something isn't working triage/not-reproducible Indicates an issue can not be reproduced as described.

Comments

@t-b
Copy link
Contributor

t-b commented Apr 11, 2024

Environment

$cat /etc/debian_version 
12.5

$g++ --version
g++ (Debian 12.2.0-14) 12.2.0

Steps to reproduce
Version: cd22f0f ([PROTO] Upgrade to opentelemetry-proto 1.2.0 (#2631), 2024-04-09)

Executing

cmake -B build -S . -DWITH_OTLP_GRPC=ON -DWITH_OTLP_HTTP=ON -DWITH_ABSEIL=ON -DBUILD_TESTING=OFF -DWITH_BENCHMARK=OFF -DCMAKE_CXX_STANDARD=17

gives

[ 75%] Built target batch_span_processor_example
/home/firma/devel/opentelemetry-cpp/exporters/otlp/src/otlp_recordable.cc: In member function ‘virtual void opentelemetry::v1::exporter::otlp::OtlpRecordable::SetTraceFlags(opentelemetry::v1::trace::TraceFlags)’:
/home/firma/devel/opentelemetry-cpp/exporters/otlp/src/otlp_recordable.cc:145:73: error: ‘SPAN_FLAGS_TRACE_FLAGS_MASK’ is not a member of ‘opentelemetry::proto::trace::v1’
  145 |   uint32_t all_flags = flags.flags() & opentelemetry::proto::trace::v1::SPAN_FLAGS_TRACE_FLAGS_MASK;
      |                                                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/firma/devel/opentelemetry-cpp/exporters/otlp/src/otlp_recordable.cc:147:9: error: ‘class opentelemetry::proto::trace::v1::Span’ has no member named ‘set_flags’
  147 |   span_.set_flags(all_flags);
      |         ^~~~~~~~~

@t-b t-b added the bug Something isn't working label Apr 11, 2024
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 11, 2024
@marcalff
Copy link
Member

It seems this build still sees opentelemetry-proto 1.0.0.

If using an external opentelemetry-proto, make sure to use version 1.2.0

If using submodules located under third_party, make sure to update submodules when pulling from github.

For example:

cd third_party/opentelemetry-proto
git log

should read as:

commit 24d4bc002003c74db7aa608c8e254155daf8e49d (HEAD, tag: v1.2.0)
Author: Carlos Alberto Cortez <calberto.cortez@gmail.com>
Date:   Fri Apr 5 22:26:48 2024 +0200

    Prepare Release 1.2.0 (#537)

@marcalff marcalff self-assigned this Apr 15, 2024
@t-b
Copy link
Contributor Author

t-b commented Apr 15, 2024

This fixed it. Thanks.

@t-b t-b closed this as completed Apr 15, 2024
@marcalff marcalff added triage/not-reproducible Indicates an issue can not be reproduced as described. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage/not-reproducible Indicates an issue can not be reproduced as described.
Projects
None yet
Development

No branches or pull requests

2 participants