-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is formating for log messages actually implemented? #2628
Comments
Perhaps this needs to be documented better. The formatting of the message is not done by OpenTelemetry SDK, but the onus is on upstream agents or exporters who want the support. |
I suggest to make this into a bug that requests to improve documentation. I believe I found nothing to this effect in the Docs or any code comments. |
This issue was marked as stale due to lack of activity. |
Does the Logging API spec include support for a format string? (I wasn't able to find it.) I was under the impression that the user-facing API should adhere closely to the spec. @ThomsonTan who originally added the API might know more about the design. For example, was the goal to propose format strings to the spec with C++ as a reference implementation? |
The otel-cpp logging API has two parts
Otel specs only specify the bridge-api which is used to create appenders for the use-facing API. The specs doesn't specify a user-facing API, as most languages already have their own logging frameworks. Regarding format string, it is only part of user-facing api, and get |
Hello @lalitb assuming this is a beginner friendly I'd like to work on this issue. Is it still open for contributions? |
I am trying to use formatting for log messages as suggested in
opentelemetry-cpp/api/include/opentelemetry/logs/logger.h
Line 287 in e86ceba
Q: Is it actually implemented?
Q: Do you have an example code for me? Something like:
The text was updated successfully, but these errors were encountered: