Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make WITH_ASYNC_EXPORT_PREVIEW mainstream #2364

Open
marcalff opened this issue Oct 12, 2023 · 12 comments
Open

Make WITH_ASYNC_EXPORT_PREVIEW mainstream #2364

marcalff opened this issue Oct 12, 2023 · 12 comments
Labels
bug Something isn't working Stale triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@marcalff
Copy link
Member

To discuss.

Asynchronous export has been stable for a while.

The preview flag can be removed, and the code be mainstream (without ifdef).

This will decrease the overall complexity, and simplify CI builds.

@marcalff marcalff added the bug Something isn't working label Oct 12, 2023
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 12, 2023
@lalitb
Copy link
Member

lalitb commented Oct 12, 2023

If I remember correctly, Async export was put under feature flag as it is not specs compliant. It calls Export::export simultaneously without waiting for previous call to end.

@marcalff
Copy link
Member Author

If I remember correctly, Async export was put under feature flag as it is not specs compliant. It calls Export::export simultaneously without waiting for previous call to end.

Good to know.

In that case, we should investigate which parts are still missing and not compliant, so it gets resolved over time, instead of keeping a feature flag forever.

@lalitb
Copy link
Member

lalitb commented Oct 12, 2023

This was a feature provided for those looking for high throughput at the expense of deviating from the specifications. I don't think the plan was ever to make this compliant.

@ThomsonTan
Copy link
Contributor

Is it possible to move the async exporter to contrib repo then, if it is not in the spec?

@lalitb
Copy link
Member

lalitb commented Oct 12, 2023

Thats a good idea. Though won’t be easy as I think this preview flag is both in batch processor and exporter.

@owent
Copy link
Member

owent commented Oct 13, 2023

@owent
Copy link
Member

owent commented Oct 13, 2023

Aync exporting for OTLP gRPC exporter do not implemented yet.

@marcalff marcalff added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 18, 2023
@marcalff
Copy link
Member Author

To summarize:

  • HTTP async is in the spec, and implemented
  • GRPC async is in the spec, but not implemented
  • the name WITH_ASYNC_EXPORT_PREVIEW is not specific to HTTP or GRPC

To discuss, possible options:

  • wait for the GRPC async implementation, and put both mainstream much later
  • make HTTP async mainstream now, and use a different feature flag later for GRPC (WITH_GRPC_ASYNC_EXPORT_PREVIEW)

@owent
Copy link
Member

owent commented Oct 19, 2023

To summarize:

  • HTTP async is in the spec, and implemented
  • GRPC async is in the spec, but not implemented
  • the name WITH_ASYNC_EXPORT_PREVIEW is not specific to HTTP or GRPC

To discuss, possible options:

  • wait for the GRPC async implementation, and put both mainstream much later
  • make HTTP async mainstream now, and use a different feature flag later for GRPC (WITH_GRPC_ASYNC_EXPORT_PREVIEW)

Maybe I will have time to implement gRPC async exporting one or two weeks later. Personally I prefer to keep WITH_ASYNC_EXPORT_PREVIEW now.

Copy link

This issue was marked as stale due to lack of activity.

@github-actions github-actions bot added the Stale label Dec 19, 2023
@owent
Copy link
Member

owent commented Dec 19, 2023

Maybe WITH_GRPC_ASYNC_EXPORT_PREVIEW can be removed after #2407 is merged and test it for some time.

@github-actions github-actions bot removed the Stale label Dec 21, 2023
Copy link

This issue was marked as stale due to lack of activity.

@github-actions github-actions bot added the Stale label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stale triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants