-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make WITH_ASYNC_EXPORT_PREVIEW
mainstream
#2364
Comments
If I remember correctly, Async export was put under feature flag as it is not specs compliant. It calls Export::export simultaneously without waiting for previous call to end. |
Good to know. In that case, we should investigate which parts are still missing and not compliant, so it gets resolved over time, instead of keeping a feature flag forever. |
This was a feature provided for those looking for high throughput at the expense of deviating from the specifications. I don't think the plan was ever to make this compliant. |
Is it possible to move the async exporter to contrib repo then, if it is not in the spec? |
Thats a good idea. Though won’t be easy as I think this preview flag is both in batch processor and exporter. |
It's in spec but optional. https://github.com/open-telemetry/opentelemetry-proto/blob/main/docs/specification.md#otlpgrpc-concurrent-requests |
Aync exporting for OTLP gRPC exporter do not implemented yet. |
To summarize:
To discuss, possible options:
|
Maybe I will have time to implement gRPC async exporting one or two weeks later. Personally I prefer to keep |
This issue was marked as stale due to lack of activity. |
Maybe |
This issue was marked as stale due to lack of activity. |
To discuss.
Asynchronous export has been stable for a while.
The preview flag can be removed, and the code be mainstream (without ifdef).
This will decrease the overall complexity, and simplify CI builds.
The text was updated successfully, but these errors were encountered: