You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks, agree CURL checks can be much simplified. Later, once #1145 and #1146 are implemented, with native HTTP client libraries used for Windows and Mac, CURL can be made mandatory only for POSIX.
Per the CMake makefiles:
CMake should not call find_package(CURL) so many times from nested directories.
Beside, the current logic is questionable:
If
CURL
is not found andBUILD_W3CTRACECONTEXT_TEST
is set, the build should fail, not pass and do nothing.Instead:
USE_NLOHMANN_JSON
Implementing this cleanup will help to add the CURL dependency from different sources (git submodule, external project, alternate location).
The text was updated successfully, but these errors were encountered: