Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why boundaries is std::list #1864

Closed
lalitb opened this issue Dec 14, 2022 Discussed in #1863 · 1 comment · Fixed by #1869
Closed

Why boundaries is std::list #1864

lalitb opened this issue Dec 14, 2022 Discussed in #1863 · 1 comment · Fixed by #1869
Assignees
Labels
area:metrics OpenTelemetry metrics

Comments

@lalitb
Copy link
Member

lalitb commented Dec 14, 2022

Discussed in #1863

Originally posted by ondra-novak December 14, 2022

Just explain me, why list is used here. Unless you need to insert into or erase from inside of the list, this container is very slow and you are loosing a lot of performance here.

This has been changed from std::vector in commit a7e814a without any sign of need such a change and without explanation.

@lalitb
Copy link
Member Author

lalitb commented Dec 14, 2022

I can't recall why this was done now, but agree std::vector ( or perhaps std::array) would be more efficient. Creating a issue out of it. Thanks for raising the query.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics OpenTelemetry metrics
Projects
None yet
1 participant