Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decode values from OTEL_RESOURCE_ATTRIBUTES #1536

Open
lgfa29 opened this issue Jul 31, 2022 · 5 comments
Open

Decode values from OTEL_RESOURCE_ATTRIBUTES #1536

lgfa29 opened this issue Jul 31, 2022 · 5 comments
Labels
do-not-stale enhancement New feature or request help wanted Good for taking. Extra help will be provided by maintainers spec-compliance Not compliant to OpenTelemetry specs

Comments

@lgfa29
Copy link

lgfa29 commented Jul 31, 2022

While using the Go SDK I noticed an inconsistency in how OTEL_RESOURCE_ATTRIBUTES baggage values are encoded and decoded. This was due to a difference in the version of the W3C Baggage spec used for baggage propagation and the OTEL_RESOURCE_ATTRIBUTES decoding.

open-telemetry/opentelemetry-specification#2670 updates the W3C Baggage spec version used by the Resource spec to require percent-decoding values from OTEL_RESOURCE_ATTRIBUTES.
@lalitb
Copy link
Member

lalitb commented Aug 1, 2022

This seems to be for Go SDK. Please open it here - https://github.com/open-telemetry/opentelemetry-go/issues

@lalitb lalitb closed this as completed Aug 1, 2022
@lalitb lalitb reopened this Aug 1, 2022
@lalitb
Copy link
Member

lalitb commented Aug 1, 2022

My bad. This is relevant for C++ SDK too :)

@lalitb lalitb added enhancement New feature or request spec-compliance Not compliant to OpenTelemetry specs labels Aug 1, 2022
@lgfa29
Copy link
Author

lgfa29 commented Aug 2, 2022

Ah yes, this started with a Go SDK change, but evolved into a spec change that affects all SDKs. Sorry for not making this clear in the original issue 😅

@lalitb lalitb added the help wanted Good for taking. Extra help will be provided by maintainers label Aug 15, 2022
@github-actions
Copy link

This issue was marked as stale due to lack of activity.

@github-actions github-actions bot added the Stale label Oct 15, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 23, 2022
@lalitb lalitb reopened this Oct 23, 2022
@lalitb lalitb added do-not-stale and removed Stale labels Oct 23, 2022
@marcalff
Copy link
Member

marcalff commented Mar 7, 2024

Related: #2579

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
do-not-stale enhancement New feature or request help wanted Good for taking. Extra help will be provided by maintainers spec-compliance Not compliant to OpenTelemetry specs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lgfa29 @lalitb @marcalff