New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url parser will incorrect parsing url like "http://aaa.com/eee@bbb/x/y" #1509

Closed

wangzhen2271 opened this issue Jul 21, 2022 · 1 comment

Labels

bug

Contributor

wangzhen2271 commented Jul 21, 2022 •

edited

Loading

I report trace to url "http://tracing-analysis-dc-hz.aliyuncs.com/adapt_fdufe5deml@455595430f299c1_fdffe5degl@134f7ad2ffe83/api/otlp/traces". It always failed, I trace the code and found the urlparser take a mistake, the parse result is: host -- 455595430f299c1_fdffe5degl@134f7ad2ffe83 while it should be -- tracing-analysis-dc-hz.aliyuncs.com.

I think the "@" should be considered just when it in the first segment, so this should be fixed.

I want to submit a pull request to fix it.

wangzhen2271 added the bug label

wangzhen2271 mentioned this issue

fix: urlParser will incorrect parsing url like http://abc.com/xxx@xxx/a/b #1511

Merged

3 tasks

Member

esigo commented Jul 24, 2022

already fixed in #1511.

esigo closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment