From fe0c62fec8fcce4f91d1a056c4f181722594ee38 Mon Sep 17 00:00:00 2001 From: Marc Alff Date: Thu, 22 Sep 2022 04:11:11 +0200 Subject: [PATCH 1/9] [Semantic Conventions] Align on the specification 1.13.0 (#1625) * Fix #1624 * Added changelog --- CHANGELOG.md | 1 + .../trace/semantic_conventions.h | 206 +++++++++++------- buildscripts/semantic-convention/generate.sh | 4 +- examples/grpc/client.cc | 2 +- examples/http/server.cc | 2 +- .../sdk/resource/semantic_conventions.h | 7 +- 6 files changed, 134 insertions(+), 88 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 26195e04bd..eb11fe2ba2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -20,6 +20,7 @@ Increment the: [#1606](https://github.com/open-telemetry/opentelemetry-cpp/pull/1606) * [METRICS EXPORTER] Add `OtlpGrpcClient` [#1606](https://github.com/open-telemetry/opentelemetry-cpp/pull/1606) * [BUILD] Fix header only api singletons [#1604](https://github.com/open-telemetry/opentelemetry-cpp/pull/1604) +* [SEMANTIC CONVENTIONS] Upgrade to version 1.13.0 [#1624](https://github.com/open-telemetry/opentelemetry-cpp/pull/1624) ## [1.6.0] 2022-08-15 diff --git a/api/include/opentelemetry/trace/semantic_conventions.h b/api/include/opentelemetry/trace/semantic_conventions.h index 2334ced67b..93bb86d789 100644 --- a/api/include/opentelemetry/trace/semantic_conventions.h +++ b/api/include/opentelemetry/trace/semantic_conventions.h @@ -33,7 +33,7 @@ namespace SemanticConventions /** * The URL of the OpenTelemetry schema for these keys and values. */ -static constexpr const char *SCHEMA_URL = "https://opentelemetry.io/schemas/1.12.0"; +static constexpr const char *SCHEMA_URL = "https://opentelemetry.io/schemas/1.13.0"; /** * The full invoked ARN as provided on the {@code Context} passed to the function ({@code @@ -355,18 +355,45 @@ static constexpr const char *FAAS_INVOKED_REGION = "faas.invoked_region"; static constexpr const char *NET_TRANSPORT = "net.transport"; /** - * Remote address of the peer (dotted decimal for IPv4 or RFC5952 for IPv6) + * Application layer protocol used. The value SHOULD be normalized to lowercase. */ -static constexpr const char *NET_PEER_IP = "net.peer.ip"; +static constexpr const char *NET_APP_PROTOCOL_NAME = "net.app.protocol.name"; /** - * Remote port number. + * Version of the application layer protocol used. See note below. + * + *

Notes: +

*/ -static constexpr const char *NET_PEER_PORT = "net.peer.port"; +static constexpr const char *NET_APP_PROTOCOL_VERSION = "net.app.protocol.version"; + +/** + * Remote socket peer name. + */ +static constexpr const char *NET_SOCK_PEER_NAME = "net.sock.peer.name"; + +/** + * Remote socket peer address: IPv4 or IPv6 for internet protocols, path for local communication, etc. + */ +static constexpr const char *NET_SOCK_PEER_ADDR = "net.sock.peer.addr"; /** - * Remote hostname or similar, see note below. + * Remote socket peer port. + */ +static constexpr const char *NET_SOCK_PEER_PORT = "net.sock.peer.port"; + +/** + * Protocol address + * family which is used for communication. + */ +static constexpr const char *NET_SOCK_FAMILY = "net.sock.family"; + +/** + * Logical remote hostname, see note below. * *

Notes: