diff --git a/CHANGELOG.md b/CHANGELOG.md index 08bca2362e..dd3d83a082 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -467,7 +467,7 @@ update the semantic convention in instrumentation library is needed. * [BUILD] Don't require applications using jaeger exporter to know about libcurl [#1518](https://github.com/open-telemetry/opentelemetry-cpp/pull/1518) * [EXPORTER] Inline print_value() in ostream exporter [#1512](https://github.com/open-telemetry/opentelemetry-cpp/pull/1512) -* [SDK] fix: urlPaser will incorrect parsing url like "http://abc.com/xxx@xxx/a/b" +* [SDK] fix: urlPaser will incorrect parsing url like `http://abc.com/xxx@xxx/a/b` [#1511](https://github.com/open-telemetry/opentelemetry-cpp/pull/1511) * [SDK] Rename `InstrumentationLibrary` to `InstrumentationScope` [#1507](https://github.com/open-telemetry/opentelemetry-cpp/pull/1507) * [BUILD] Try to build nlohmann-json only it's depended. [#1505](https://github.com/open-telemetry/opentelemetry-cpp/pull/1505) diff --git a/exporters/otlp/CMakeLists.txt b/exporters/otlp/CMakeLists.txt index 8ab053c9cc..31bf627b0b 100644 --- a/exporters/otlp/CMakeLists.txt +++ b/exporters/otlp/CMakeLists.txt @@ -36,7 +36,8 @@ if(WITH_OTLP_GRPC) target_link_libraries( opentelemetry_exporter_otlp_grpc_client - PUBLIC opentelemetry_sdk opentelemetry_ext opentelemetry_proto) + PUBLIC opentelemetry_sdk opentelemetry_common opentelemetry_ext + opentelemetry_proto) target_link_libraries(opentelemetry_exporter_otlp_grpc_client PRIVATE gRPC::grpc++) diff --git a/ext/src/http/client/curl/CMakeLists.txt b/ext/src/http/client/curl/CMakeLists.txt index 96e7c5b42a..7e2507bd75 100644 --- a/ext/src/http/client/curl/CMakeLists.txt +++ b/ext/src/http/client/curl/CMakeLists.txt @@ -8,7 +8,8 @@ add_library( set_target_properties(opentelemetry_http_client_curl PROPERTIES EXPORT_NAME http_client_curl) set_target_version(opentelemetry_http_client_curl) - +target_link_libraries(opentelemetry_http_client_curl + PUBLIC opentelemetry_common) if(TARGET CURL::libcurl) target_link_libraries( opentelemetry_http_client_curl diff --git a/sdk/src/metrics/CMakeLists.txt b/sdk/src/metrics/CMakeLists.txt index 7ee82c9cd5..46d6d67212 100644 --- a/sdk/src/metrics/CMakeLists.txt +++ b/sdk/src/metrics/CMakeLists.txt @@ -24,7 +24,8 @@ add_library( set_target_properties(opentelemetry_metrics PROPERTIES EXPORT_NAME metrics) set_target_version(opentelemetry_metrics) -target_link_libraries(opentelemetry_metrics PUBLIC opentelemetry_common) +target_link_libraries(opentelemetry_metrics PUBLIC opentelemetry_common + opentelemetry_resources) target_include_directories( opentelemetry_metrics