[BUILD] error: read-only reference ‘value’ used as ‘asm’ output (#2354)

marcalff · web-flow · commit 05b26cae87ac · 2023-10-10T01:30:27.000+02:00
diff --git a/sdk/test/trace/sampler_benchmark.cc b/sdk/test/trace/sampler_benchmark.cc
@@ -42,6 +42,11 @@ void BM_AlwaysOnSamplerConstruction(benchmark::State &state)
 }
 BENCHMARK(BM_AlwaysOnSamplerConstruction);
 
+/*
+  Fails to build with GCC.
+  See upstream bug: https://github.com/google/benchmark/issues/1675
+*/
+#if 0
 void BM_ParentBasedSamplerConstruction(benchmark::State &state)
 {
   while (state.KeepRunning())
@@ -59,6 +64,7 @@ void BM_TraceIdRatioBasedSamplerConstruction(benchmark::State &state)
   }
 }
 BENCHMARK(BM_TraceIdRatioBasedSamplerConstruction);
+#endif
 
 // Sampler Helper Function
 void BenchmarkShouldSampler(Sampler &sampler, benchmark::State &state)

Original file line number	Diff line number	Diff line change
`@@ -42,6 +42,11 @@ void BM_AlwaysOnSamplerConstruction(benchmark::State &state)`
`42`	`42`	`}`
`43`	`43`	`BENCHMARK(BM_AlwaysOnSamplerConstruction);`
`44`	`44`
	`45`	`+/*`
	`46`	`+ Fails to build with GCC.`
	`47`	`+ See upstream bug: https://github.com/google/benchmark/issues/1675`
	`48`	`+*/`
	`49`	`+#if 0`
`45`	`50`	`void BM_ParentBasedSamplerConstruction(benchmark::State &state)`
`46`	`51`	`{`
`47`	`52`	`while (state.KeepRunning())`
`@@ -59,6 +64,7 @@ void BM_TraceIdRatioBasedSamplerConstruction(benchmark::State &state)`
`59`	`64`	`}`
`60`	`65`	`}`
`61`	`66`	`BENCHMARK(BM_TraceIdRatioBasedSamplerConstruction);`
	`67`	`+#endif`
`62`	`68`
`63`	`69`	`// Sampler Helper Function`
`64`	`70`	`void BenchmarkShouldSampler(Sampler &sampler, benchmark::State &state)`