Skip to content

Commit

Permalink
[BUILD] error: read-only reference ‘value’ used as ‘asm’ output (#2354)
Browse files Browse the repository at this point in the history
  • Loading branch information
marcalff authored Oct 9, 2023
1 parent 0eaa794 commit 05b26ca
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions sdk/test/trace/sampler_benchmark.cc
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,11 @@ void BM_AlwaysOnSamplerConstruction(benchmark::State &state)
}
BENCHMARK(BM_AlwaysOnSamplerConstruction);

/*
Fails to build with GCC.
See upstream bug: https://github.com/google/benchmark/issues/1675
*/
#if 0
void BM_ParentBasedSamplerConstruction(benchmark::State &state)
{
while (state.KeepRunning())
Expand All @@ -59,6 +64,7 @@ void BM_TraceIdRatioBasedSamplerConstruction(benchmark::State &state)
}
}
BENCHMARK(BM_TraceIdRatioBasedSamplerConstruction);
#endif

// Sampler Helper Function
void BenchmarkShouldSampler(Sampler &sampler, benchmark::State &state)
Expand Down

0 comments on commit 05b26ca

Please sign in to comment.