Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[confignet] Remove deprecated structs #9614

Merged

Conversation

TylerHelmuth
Copy link
Member

Description:
Removes deprecated structs

Link to tracking Issue:
Closes #9509

@TylerHelmuth TylerHelmuth requested review from a team and codeboten February 20, 2024 18:32
@TylerHelmuth TylerHelmuth added the release:required-for-ga Must be resolved before GA release label Feb 20, 2024
@TylerHelmuth TylerHelmuth force-pushed the confignet-remove-deprecated-structs branch from 6f23ddb to 15ccb8e Compare February 20, 2024 18:38
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ae90430) 90.69% compared to head (f228b1c) 90.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9614      +/-   ##
==========================================
+ Coverage   90.69%   90.70%   +0.01%     
==========================================
  Files         347      347              
  Lines       18210    18210              
==========================================
+ Hits        16515    16518       +3     
+ Misses       1371     1369       -2     
+ Partials      324      323       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu
Copy link
Member

@TylerHelmuth can you fix contrib please?

@TylerHelmuth
Copy link
Member Author

@TylerHelmuth
Copy link
Member Author

Although we need to wait for the Contrib release to finish

@TylerHelmuth
Copy link
Member Author

open-telemetry/opentelemetry-collector-contrib#31354 is ready for review

@dmitryax dmitryax merged commit bdcdff4 into open-telemetry:main Feb 22, 2024
46 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 22, 2024
@TylerHelmuth TylerHelmuth deleted the confignet-remove-deprecated-structs branch February 22, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:required-for-ga Must be resolved before GA release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[confignet] Should we change the name of NetAddr and NetTCP to end in Config?
3 participants