Remove noisy log statement #9018
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9018 +/- ##
==========================================
- Coverage 91.57% 91.57% -0.01%
==========================================
Files 316 316
Lines 17147 17146 -1
==========================================
- Hits 15702 15701 -1
Misses 1150 1150
Partials 295 295 ☔ View full report in Codecov by Sentry. |
| @@ -117,7 +117,6 @@ func (rs *retrySender) send(ctx context.Context, req Request) error { | |||
| trace.WithAttributes(rs.traceAttribute, attribute.Int64("retry_num", retryNum))) | |||
|
|
|||
| err := rs.nextSender.send(ctx, req) | |||
| rs.logger.Info("Exporting finished.", zap.Error(err)) | |||
There was a problem hiding this comment.
Should we switch it to a Debug? Or would it be too noisy even for that?
There was a problem hiding this comment.
imo it's not useful. The error is logged if present a few lines below, and I don't see value in outputting a debug statement that an export is done, when we also have tracing and span events collected around those lines.
atoulme
force-pushed
the
remove_noisy_log
branch
from
87b4a06
to
5b7bd44
Compare
If we are going to do a bugfix release for this, we should follow the release procedure on https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/release.md#bugfix-release-procedure, which makes it less likely that we will get things wrong re:go dependencies |
|
@atoulme thanks for the fix! |
|
Please rebase |
atoulme
force-pushed
the
remove_noisy_log
branch
from
5b7bd44
to
65bc7b8
Compare
|
Rebased, sorry. |
Removes a noisy log statement Fixes open-telemetry#9017
#9018 against the patch release branch Co-authored-by: Antoine Toulme <antoine@lunar-ocean.com>
open-telemetry#9018 against the patch release branch Co-authored-by: Antoine Toulme <antoine@lunar-ocean.com>
Removes a noisy log statement Fixes open-telemetry#9017
open-telemetry#9018 against the patch release branch Co-authored-by: Antoine Toulme <antoine@lunar-ocean.com>
open-telemetry#9018 against the patch release branch Co-authored-by: Antoine Toulme <antoine@lunar-ocean.com>
Description:
Removes a noisy log statement
Link to tracking Issue:
Fixes #9017