Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add span processor configuration #8117

Merged

Conversation

codeboten
Copy link
Contributor

This PR adds support for configuring batch span processor for internal
collector traces. It adds support to export them via the stdout exporter.

Linked issue #8106

Follows #8097

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage: 91.33% and project coverage change: +0.01 🎉

Comparison is base (a1efc0e) 90.18% compared to head (6045a82) 90.19%.

❗ Current head 6045a82 differs from pull request most recent head f68b5d3. Consider uploading reports for the commit f68b5d3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8117      +/-   ##
==========================================
+ Coverage   90.18%   90.19%   +0.01%     
==========================================
  Files         301      301              
  Lines       15377    15526     +149     
==========================================
+ Hits        13868    14004     +136     
- Misses       1222     1231       +9     
- Partials      287      291       +4     
Impacted Files Coverage Δ
service/telemetry.go 82.11% <62.50%> (-2.44%) ⬇️
service/telemetry/config.go 91.11% <77.77%> (-8.89%) ⬇️
service/internal/proctelemetry/config.go 96.00% <97.39%> (+1.30%) ⬆️
service/service.go 76.21% <100.00%> (+0.14%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codeboten
Copy link
Contributor Author

Sample output:

{
        "Name": "exporter/otlp/ls/traces",
        "SpanContext": {
                "TraceID": "c9fd6d1e2afb0f062fd11b86657a71b5",
                "SpanID": "278a66cba25fa420",
                "TraceFlags": "01",
                "TraceState": "",
                "Remote": false
        },
        "Parent": {
                "TraceID": "00000000000000000000000000000000",
                "SpanID": "0000000000000000",
                "TraceFlags": "00",
                "TraceState": "",
                "Remote": false
        },
        "SpanKind": 1,
        "StartTime": "2023-07-20T13:32:22.746457-07:00",
        "EndTime": "2023-07-20T13:32:22.937081125-07:00",
        "Attributes": [
                {
                        "Key": "sent_spans",
                        "Value": {
                                "Type": "INT64",
                                "Value": 20
                        }
                },
                {
                        "Key": "send_failed_spans",
                        "Value": {
                                "Type": "INT64",
                                "Value": 0
                        }
                }
        ],
        "Events": [
                {
                        "Name": "Sending request.",
                        "Attributes": [
                                {
                                        "Key": "exporter",
                                        "Value": {
                                                "Type": "STRING",
                                                "Value": "otlp/ls"
                                        }
                                },
                                {
                                        "Key": "retry_num",
                                        "Value": {
                                                "Type": "INT64",
                                                "Value": 0
                                        }
                                }
                        ],
                        "DroppedAttributeCount": 0,
                        "Time": "2023-07-20T13:32:22.746487-07:00"
                }
        ],
        "Links": null,
        "Status": {
                "Code": "Unset",
                "Description": ""
        },
        "DroppedAttributes": 0,
        "DroppedEvents": 0,
        "DroppedLinks": 0,
        "ChildSpanCount": 1,
        "Resource": [
                {
                        "Key": "service.instance.id",
                        "Value": {
                                "Type": "STRING",
                                "Value": "6cc516f2-a726-4870-8095-1e6a61f4fc06"
                        }
                },
                {
                        "Key": "service.name",
                        "Value": {
                                "Type": "STRING",
                                "Value": "otelcorecol"
                        }
                },
                {
                        "Key": "service.version",
                        "Value": {
                                "Type": "STRING",
                                "Value": "0.81.0-dev"
                        }
                }
        ],
        "InstrumentationLibrary": {
                "Name": "otlp/ls",
                "Version": "",
                "SchemaURL": ""
        }
}

codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this pull request Jul 20, 2023
This PR adds support for exporting internal collector traces via the
OTel Go OTLP exporters.

Closes open-telemetry#8106

Follows open-telemetry#8117

Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten force-pushed the codeboten/add-tracer-provider branch from 1f30fae to f46a284 Compare July 21, 2023 14:45
@codeboten codeboten marked this pull request as ready for review July 21, 2023 14:45
@codeboten codeboten requested review from a team and djaglowski July 21, 2023 14:45
@codeboten codeboten force-pushed the codeboten/add-tracer-provider branch from f46a284 to c039bfa Compare July 21, 2023 15:17
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this pull request Jul 21, 2023
This PR adds support for exporting internal collector traces via the
OTel Go OTLP exporters.

Closes open-telemetry#8106

Follows open-telemetry#8117

Signed-off-by: Alex Boten <aboten@lightstep.com>
This PR adds support for configuring batch span processor for internal
collector traces. It adds support to export them via the stdout exporter.

Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten force-pushed the codeboten/add-tracer-provider branch from 6045a82 to f68b5d3 Compare July 21, 2023 20:42
@codeboten codeboten merged commit 5613523 into open-telemetry:main Jul 21, 2023
28 of 29 checks passed
@codeboten codeboten deleted the codeboten/add-tracer-provider branch July 21, 2023 21:40
@github-actions github-actions bot added this to the next release milestone Jul 21, 2023
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this pull request Jul 21, 2023
This PR adds support for exporting internal collector traces via the
OTel Go OTLP exporters.

Closes open-telemetry#8106

Follows open-telemetry#8117

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit that referenced this pull request Aug 24, 2023
This PR adds support for exporting internal collector traces via the
OTel Go OTLP exporters.

Closes
#8106

~Follows
#8117

---------

Signed-off-by: Alex Boten <aboten@lightstep.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants