[chore] use multimod diff #8024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #8024 +/- ##
==========================================
- Coverage 90.74% 90.70% -0.04%
==========================================
Files 300 300
Lines 15164 15164
==========================================
- Hits 13760 13754 -6
- Misses 1123 1128 +5
- Partials 281 282 +1 ☔ View full report in Codecov by Sentry. |
codeboten
force-pushed
the
codeboten/fix-makefile-target
branch
from
3fd3395
to
4f681f2
Compare
mx-psi
reviewed
Jul 11, 2023
|
@mx-psi sure, here's the PR open-telemetry/opentelemetry-go-build-tools#361 |
codeboten
force-pushed
the
codeboten/fix-makefile-target
branch
from
4f681f2
to
347d0c6
Compare
bumped to v0.9.0 |
mx-psi
approved these changes
Jul 12, 2023
The logic from check-changes was moved to multimod diff. Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten
force-pushed
the
codeboten/fix-makefile-target
branch
from
347d0c6
to
54b7e98
Compare
jpkrohling
added a commit
to jpkrohling/opentelemetry-collector
that referenced
this pull request
Jul 26, 2023
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
dmitryax
pushed a commit
that referenced
this pull request
Jul 26, 2023
This PR reverts #8024, as it introduced a new behavior, causing the release to be blocked. Apparently, multimod has a return code of 1 when diffs are seen, causing the prepare-release target to break. After this release, we can try to get multimod to behave in the same way as this PR. Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
codeboten
pushed a commit
to codeboten/opentelemetry-collector
that referenced
this pull request
Sep 25, 2023
This is revert-ing the revert of open-telemetry#8024 Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten
pushed a commit
that referenced
this pull request
Sep 25, 2023
sokoide
pushed a commit
to sokoide/opentelemetry-collector
that referenced
this pull request
Dec 18, 2023
It's not need after open-telemetry#8024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic from
check-changeswas moved to multimod diff.Fixes #8012