Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[loggingexporter] Fix display of bucket boundaries of exponential histograms #7445

Conversation

alanwest
Copy link
Member

The interval notation used for displaying bucket boundaries of exponential histograms was incorrect.

Should be:
Negative buckets -> lower bound is inclusive, upper bound exclusive
Positive buckets -> lower bound is exclusive, upper bound inclusive

See: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/data-model.md#exponential-buckets

The ExponentialHistogram bucket identified by index, a signed integer, represents values in the population that are greater than base**index and less than or equal to base**(index+1).

The positive and negative ranges of the histogram are expressed separately. Negative values are mapped by their absolute value into the negative range using the same scale as the positive range. Note that in the negative range, therefore, histogram buckets use lower-inclusive boundaries.

@alanwest alanwest requested review from a team and codeboten March 28, 2023 19:59
@dmitryax dmitryax merged commit 4c24bdc into open-telemetry:main Mar 28, 2023
@github-actions github-actions bot added this to the next release milestone Mar 28, 2023
@alanwest alanwest deleted the alanwest/loggingexporter-exponential-histogram-fix branch March 28, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants