Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processorhelper] remove deprecated funcs #11151

Merged

Conversation

codeboten
Copy link
Contributor

No description provided.

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten requested review from a team and dmitryax September 11, 2024 22:45
.chloggen/main.yaml Outdated Show resolved Hide resolved
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atoulme
Copy link
Contributor

atoulme commented Sep 12, 2024

Please take a look at the CI:

# go.opentelemetry.io/collector/processor/processorhelper [go.opentelemetry.io/collector/processor/processorhelper.test]
Error: processorhelper\obsreport_test.go:40:10: obsrep.TracesInserted undefined (type *ObsReport has no field or method TracesInserted)
Error: processorhelper\obsreport_test.go:61:10: obsrep.MetricsInserted undefined (type *ObsReport has no field or method MetricsInserted)
Error: processorhelper\obsreport_test.go:104:10: obsrep.LogsInserted undefined (type *ObsReport has no field or method LogsInserted)
Error: processorhelper\obsreport_test.go:124:6: por.TracesInserted undefined (type *ObsReport has no field or method TracesInserted)
Error: processorhelper\obsreport_test.go:158:6: por.MetricsInserted undefined (type *ObsReport has no field or method MetricsInserted)
Error: processorhelper\obsreport_test.go:192:6: por.LogsInserted undefined (type *ObsReport has no field or method LogsInserted)
Error: processorhelper\obsreport_test.go:234:7: por.TracesInserted undefined (type *ObsReport has no field or method TracesInserted)
Error: processorhelper\obsreport_test.go:258:7: por.MetricsInserted undefined (type *ObsReport has no field or method MetricsInserted)
Error: processorhelper\obsreport_test.go:282:7: por.LogsInserted undefined (type *ObsReport has no field or method LogsInserted)

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 92.31%. Comparing base (0e22dc3) to head (d821cac).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
component/componenttest/obsreporttest.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11151      +/-   ##
==========================================
+ Coverage   92.26%   92.31%   +0.05%     
==========================================
  Files         414      413       -1     
  Lines       19802    19767      -35     
==========================================
- Hits        18270    18248      -22     
+ Misses       1160     1149      -11     
+ Partials      372      370       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten merged commit 3bcb341 into open-telemetry:main Sep 12, 2024
48 of 49 checks passed
@codeboten codeboten deleted the codeboten/rm-deprecated-obsreport2 branch September 12, 2024 18:34
@github-actions github-actions bot added this to the next release milestone Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants