[service] fix proctelemetry registration bug #11093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11093 +/- ##
==========================================
+ Coverage 92.23% 92.28% +0.05%
==========================================
Files 414 414
Lines 19810 19798 -12
==========================================
- Hits 18271 18270 -1
+ Misses 1167 1156 -11
Partials 372 372 ☔ View full report in Codecov by Sentry. |
dmitryax
approved these changes
Sep 10, 2024
bogdandrutu
reviewed
Sep 10, 2024
bogdandrutu
approved these changes
Sep 10, 2024
This bug caused proctelemetry metrics to not be registered if a user configured the Collector's internal telemetry via `readers` only and disabled `address`. The check in the `if` statement is no longer needed since a no-op meter provider will be configured unless the telemetry level is set. Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten
force-pushed
the
codeboten/fix-bug
branch
from
c757181
to
0e1a0dc
Compare
TylerHelmuth
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug caused proctelemetry metrics to not be registered if a user configured the Collector's internal telemetry via
readersonly and disabledaddress. The check in theifstatement is no longer needed since a no-op meter provider will be configured unless the telemetry level is set.Mentioned in #10919