Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogsSink/TracesSink/MetricsSink should offer a way to allow waiting until they receive data #7634

Open
atoulme opened this issue May 6, 2023 · 0 comments

Comments

@atoulme
Copy link
Contributor

atoulme commented May 6, 2023

Is your feature request related to a problem? Please describe.
Right now, we see a lot of flaky tests which end being up related to the asynchronous nature of waiting for a sink to receive test data so we can test it.

Describe the solution you'd like
Rather than use time.Sleep in tests, offer a way to use a sync.WaitGroup or another mechanism similar to allow consumers to react to the fact that the sink received data.

Describe alternatives you've considered
We can implement a separate sink class for this, or a wrapper for the sink.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant