Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Migrate 'Inform Incompatible PRs / Check-Compatibility' check to Ubuntu runner #7444

Open
mx-psi opened this issue Mar 28, 2023 · 0 comments
Labels
ci-cd CI, CD, testing, build issues enhancement New feature or request priority:p2 Medium

Comments

@mx-psi
Copy link
Member

mx-psi commented Mar 28, 2023

The 'Inform Incompatible PRs / Check-Compatibility' check runs on a macOS machine:

Check-Compatibility:
runs-on: macos-latest
This is inconsistent with the rest of our test suite, that (generally) runs on ubuntu-latest. It also eats into the org's CI minutes: 1 minute in a macOS runner is equivalent to 10 minutes on a Linux runner.

The main (only?) thing to change is this call to mktemp:

tmp_dir=$(mktemp -d -t apidiff)
which uses macOS-specific options. Changing this I am able to run this without errors on an Ubuntu machine, but we may want to tackle #7443 first to ensure the targets do not silently fail on Linux because of something else.

@mx-psi mx-psi added priority:p2 Medium ci-cd CI, CD, testing, build issues enhancement New feature or request labels Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd CI, CD, testing, build issues enhancement New feature or request priority:p2 Medium
Projects
None yet
Development

No branches or pull requests

1 participant