Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[featuregate] Clarify what ToVersion represents. #11341

Open
TylerHelmuth opened this issue Oct 3, 2024 · 0 comments
Open

[featuregate] Clarify what ToVersion represents. #11341

TylerHelmuth opened this issue Oct 3, 2024 · 0 comments
Labels
area:documentation area:featuregate bug Something isn't working

Comments

@TylerHelmuth
Copy link
Member

TylerHelmuth commented Oct 3, 2024 •
edited
Loading

The featuregate module has 2 different definitions for ToVersion.

In the godoc comments ToVersion is defined as // ToVersion returns the version information when Gate's in StageStable..

But in the README it is specified as A stable feature gate will be removed in the version specified by its ToVersion value.

We should fix whichever one is incorrect.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:documentation area:featuregate bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TylerHelmuth