Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmd/mdatagen] Add an option to generate setters from callbacks #10901

Open
dmitryax opened this issue Jul 18, 2023 · 4 comments
Open

[cmd/mdatagen] Add an option to generate setters from callbacks #10901

dmitryax opened this issue Jul 18, 2023 · 4 comments
Labels
cmd/mdatagen enhancement New feature or request help wanted Good issue for contributors to OpenTelemetry Service to pick up

Comments

@dmitryax
Copy link
Member

Component(s)

No response

Is your feature request related to a problem? Please describe.

To avoid doing unnecessary work fetching data from external sources for disabled metrics or resource attributes. Originally posted by @mx-psi in open-telemetry/opentelemetry-collector-contrib#24360 (comment)

Describe the solution you'd like

The control of how to generate the setter can be set in metadata.yaml similar to https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/apachereceiver/metadata.yaml#L66

Describe alternatives you've considered

No response

Additional context

No response
@dmitryax dmitryax added enhancement New feature or request help wanted Good issue for contributors to OpenTelemetry Service to pick up cmd/mdatagen labels Jul 18, 2023
@dmitryax dmitryax mentioned this issue Jul 18, 2023
Merged
@dmitryax dmitryax mentioned this issue Jul 28, 2023
Closed
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Sep 18, 2023
@mx-psi mx-psi removed the Stale label Sep 18, 2023
@fatsheep9146 fatsheep9146 changed the title [cdm/mdatagen] Add an option to generate setters from callbacks [cmd/mdatagen] Add an option to generate setters from callbacks Oct 20, 2023
@github-actions GitHub Actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Dec 20, 2023
@github-actions GitHub Actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 18, 2024
@dmitryax dmitryax removed the Stale label Mar 6, 2024
@dmitryax dmitryax reopened this Mar 6, 2024
@codeboten codeboten transferred this issue from open-telemetry/opentelemetry-collector-contrib Aug 16, 2024
@codeboten
Copy link
Contributor

transferred issue as mdatagen lives in the core repo now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cmd/mdatagen enhancement New feature or request help wanted Good issue for contributors to OpenTelemetry Service to pick up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@codeboten @mx-psi @dmitryax