Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize module go.opentelemetry.io/collector/filter #10349

Open
7 of 8 tasks
atoulme opened this issue Jun 6, 2024 · 5 comments
Open
7 of 8 tasks

Stabilize module go.opentelemetry.io/collector/filter #10349

atoulme opened this issue Jun 6, 2024 · 5 comments

Comments

@atoulme
Copy link
Contributor

atoulme commented Jun 6, 2024

Before stabilizing a module, an approver or maintainer must make sure that the following criteria have been met for at least two successive minor version releases (regardless of when this issue was opened):

  • No open issues or PRs in the module that would require breaking changes
  • No TODOs in the module code that would require breaking changes
  • No deprecated symbols in the module
  • No symbols marked as experimental in the module
  • The module follows the Coding guidelines

Please also make sure to publicly announce our intent to stabilize the module on:

  • The #otel-collector CNCF Slack Channel
  • The #opentelemetry CNCF Slack channel
  • A Collector SIG meeting (if unable to attend, just add to the agenda)

To help other people verify the above criteria, please link to the announcement and other links used to complete the above in a comment on this issue.

Once all criteria are met, close this issue by moving this module to the stable module set.

@atoulme
Copy link
Contributor Author

atoulme commented Jun 6, 2024

@atoulme
Copy link
Contributor Author

atoulme commented Jun 22, 2024

@dmitryax
Copy link
Member

dmitryax commented Jun 26, 2024

This is very new package. Should be considered experimental for now. I don't think it's ready for 1.0. I would suggest holding off on this one and focus on other modules for now

@mx-psi
Copy link
Member

mx-psi commented Jun 26, 2024

Would this actually be used in the Collector v1 distribution we are working on #9375? (I just want to clarify if this should be prioritized by the Collector Stability Working Group or not)

@dmitryax
Copy link
Member

Would this actually be used in the Collector v1 distribution we are working on #9375? (I just want to clarify if this should be prioritized by the Collector Stability Working Group or not)

Looks like it's not. It's currently being used by scraping receivers only. I'd suggest we wait for broader adoption of this module before declaring it 1.0. k8sattributes and docker receiver have config parts that should adopt it first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants