From d71dd31c40afd7e15eacaeb806fe1105aed388e5 Mon Sep 17 00:00:00 2001
From: Bogdan Drutu <bogdandrutu@gmail.com>
Date: Mon, 22 Feb 2021 12:17:58 -0800
Subject: [PATCH] Remove deprecated function IsValid from trace/span ID (#2522)

Updates https://github.com/open-telemetry/opentelemetry-collector/issues/2488

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
---
 CHANGELOG.md              | 4 ++++
 consumer/pdata/spanid.go  | 6 ------
 consumer/pdata/traceid.go | 6 ------
 3 files changed, 4 insertions(+), 12 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index bc9669296cf..144fcdec110 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+## 🛑 Breaking changes 🛑
+
+- Remove deprecated function `IsValid` from trace/span ID (#2522)
+
 ## v0.20.0 Beta
 
 ## 🛑 Breaking changes 🛑
diff --git a/consumer/pdata/spanid.go b/consumer/pdata/spanid.go
index 8dddf42474a..748c96a9d6b 100644
--- a/consumer/pdata/spanid.go
+++ b/consumer/pdata/spanid.go
@@ -39,12 +39,6 @@ func (t SpanID) HexString() string {
 	return data.SpanID(t).HexString()
 }
 
-// IsValid returns true if id contains at leas one non-zero byte.
-// Deprecated: use !IsEmpty() instead.
-func (t SpanID) IsValid() bool {
-	return !data.SpanID(t).IsEmpty()
-}
-
 // IsEmpty returns true if id doesn't contain at least one non-zero byte.
 func (t SpanID) IsEmpty() bool {
 	return data.SpanID(t).IsEmpty()
diff --git a/consumer/pdata/traceid.go b/consumer/pdata/traceid.go
index 976450a3ecb..3ec8276c455 100644
--- a/consumer/pdata/traceid.go
+++ b/consumer/pdata/traceid.go
@@ -39,12 +39,6 @@ func (t TraceID) HexString() string {
 	return data.TraceID(t).HexString()
 }
 
-// IsValid returns true if id contains at leas one non-zero byte.
-// Deprecated: use !IsEmpty() instead.
-func (t TraceID) IsValid() bool {
-	return !data.TraceID(t).IsEmpty()
-}
-
 // IsEmpty returns true if id doesn't contain at least one non-zero byte.
 func (t TraceID) IsEmpty() bool {
 	return data.TraceID(t).IsEmpty()