diff --git a/CHANGELOG.md b/CHANGELOG.md index 469cee6711f..30f32906f75 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,10 @@ ## Unreleased +### 🛑 Breaking changes 🛑 + +- Remove `Type` funcs in pdata (#4933) + ## v0.46.0 Beta ### 🛑 Breaking changes 🛑 diff --git a/model/pdata/metrics.go b/model/pdata/metrics.go index 39e253d2bda..a7637a7a64f 100644 --- a/model/pdata/metrics.go +++ b/model/pdata/metrics.go @@ -252,13 +252,3 @@ func (mdt MetricValueType) String() string { } return "" } - -// Deprecated: [v0.45.0] Use ValueType instead. -func (ms NumberDataPoint) Type() MetricValueType { - return ms.ValueType() -} - -// Deprecated: [v0.45.0] Use ValueType instead. -func (ms Exemplar) Type() MetricValueType { - return ms.ValueType() -} diff --git a/model/pdata/metrics_test.go b/model/pdata/metrics_test.go index 00954a3363b..e9d92696cb4 100644 --- a/model/pdata/metrics_test.go +++ b/model/pdata/metrics_test.go @@ -670,18 +670,6 @@ func TestMetricsDataPointFlags(t *testing.T) { assert.Equal(t, "FLAG_NO_RECORDED_VALUE", gauge.DataPoints().At(0).Flags().String()) } -// TestNumberDataPointType tests deprecated NumberDataPoint.Type -func TestNumberDataPointType(t *testing.T) { - tv := NewNumberDataPoint() - assert.Equal(t, tv.ValueType(), tv.Type()) -} - -// TestExemplarType tests deprecated Exemplar.Type -func TestExemplarType(t *testing.T) { - tv := NewExemplar() - assert.Equal(t, tv.ValueType(), tv.Type()) -} - func BenchmarkMetricsClone(b *testing.B) { metrics := NewMetrics() fillTestResourceMetricsSlice(metrics.ResourceMetrics())