-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the command name consistent across images #528
Comments
cc @jpkrohling |
The different configuration files is also confusing.. |
As discussed in 17-Apr-2024 - The same command could just be a symlink to ensure the change isn't breaking backwards compatibility |
Opened a separate issue for configuration consistency: #530 |
I pinged Juraci because I think this was intentional (see #59 (comment)) |
@dmitryax if we wanted to take advantage of the entrypoint in the helm chart like @jaronoff97 mentioned we'll need to update the container to use |
Created open-telemetry/opentelemetry-helm-charts#1149 for the helm chart. |
The idea behind both the config files being at different locations, and the binary names being different, is that different distributions could be installed via OS packages (rpm/deb) without interfering. From here, we have a few options:
|
Currently, we use different commands for different images.
/otelcol
for the core image/otelcol-contrib
for the contrib image (/otecontribcol
if built withmake docker-otelcontribcol
)/otelcol-k8s
for k8s imageIs there any value to having a unique command in each distro?
If not, we could use
/otelcol
consistently for every image.We can make this change gradually and support both old and new names for some time.
Initially brought in open-telemetry/opentelemetry-helm-charts#1148 (comment)
The text was updated successfully, but these errors were encountered: