[exporter/signalfx] Retry property update without tags #36044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
added a commit
that referenced
this pull request
Oct 30, 2024
Rework the tests to explicitly control requests handling by the mock server. Use channels to control start and finish of request handling instead of relying on timer and timeouts. All the tests in the package are now executed in 1.5 seconds compared to 19 seconds as before the change. This change also unblocks #36044 which can be covered after this
Property and tags updates are done in the API same call. Sometimes there are might be too many tags associated with a dimension key/value pair so the backend rejects it. We want to retry the call without tags in that situation given that properties are more valuable and should not be lost because of excessive amount of tags coming with them.
dmitryax
force-pushed
the
separate-tags-and-dimensio-updates
branch
from
41477b8 to
0c69f89
Compare
samiura
approved these changes
Oct 31, 2024
atoulme
approved these changes
Oct 31, 2024
ArthurSens
pushed a commit
to ArthurSens/opentelemetry-collector-contrib
that referenced
this pull request
Nov 4, 2024
…elemetry#36086) Rework the tests to explicitly control requests handling by the mock server. Use channels to control start and finish of request handling instead of relying on timer and timeouts. All the tests in the package are now executed in 1.5 seconds compared to 19 seconds as before the change. This change also unblocks open-telemetry#36044 which can be covered after this
ArthurSens
pushed a commit
to ArthurSens/opentelemetry-collector-contrib
that referenced
this pull request
Nov 4, 2024
…y#36044) Property and tag updates are done using the same API call. Sometimes, there might be too many tags associated with a dimension key/value pair, so the backend rejects the request. We want to retry the call without tags in that situation, given that properties are more valuable and should not be lost because of an excessive amount of tags coming with them. There is no easy way to add a unit test for this change to the current unit tests framework due to its limitations. I'm working on changing it, which will come in a separate PR.
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…elemetry#36086) Rework the tests to explicitly control requests handling by the mock server. Use channels to control start and finish of request handling instead of relying on timer and timeouts. All the tests in the package are now executed in 1.5 seconds compared to 19 seconds as before the change. This change also unblocks open-telemetry#36044 which can be covered after this
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…y#36044) Property and tag updates are done using the same API call. Sometimes, there might be too many tags associated with a dimension key/value pair, so the backend rejects the request. We want to retry the call without tags in that situation, given that properties are more valuable and should not be lost because of an excessive amount of tags coming with them. There is no easy way to add a unit test for this change to the current unit tests framework due to its limitations. I'm working on changing it, which will come in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Property and tag updates are done using the same API call. Sometimes, there might be too many tags associated with a dimension key/value pair, so the backend rejects the request. We want to retry the call without tags in that situation, given that properties are more valuable and should not be lost because of an excessive amount of tags coming with them.
There is no easy way to add a unit test for this change to the current unit tests framework due to its limitations. I'm working on changing it, which will come in a separate PR.