fix: slice init length #35848
Open
fix: slice init length #35848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntheanh201
requested review from
dmitryax,
TylerHelmuth and
a team
as code owners
| @@ -65,7 +65,7 @@ func (c *Config) Validate() error { | |||
| for _, object := range c.Objects { | |||
| gvrs, ok := validObjects[object.Name] | |||
| if !ok { | |||
| availableResource := make([]string, len(validObjects)) | |||
| availableResource := make([]string, 0, len(validObjects)) | |||
There was a problem hiding this comment.
This use case would be better improved if we set via an index instead of append.
Leaving availableResource := make([]string, len(validObjects)) but doing availableResource[i] = k feels the most efficient, since we know that every element in validObjects needs to end up in availableResource.
There was a problem hiding this comment.
we know the validObjects is a map, so if we wanna set the value to the index of availableResource, we need a counter there, IMO append is good
There was a problem hiding this comment.
Do we actually need to update availableResource @TylerHelmuth ?
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The intention here is to correct the slice initialization by setting the capacity equal to the intended length and leaving the length as 0 for dynamic appending. This avoids over-allocating or pre-allocating empty values unnecessarily.
Link to tracking issue
Fixes
Testing
Documentation