[opampsupervisor]: Skip executing the collector if no config is provided #35430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
atoulme,
evan-bradley and
tigrannajaryan
BinaryFissionGames
force-pushed
the
feat/opampsupervisor-start-stop-empty-confmap
branch
from
014352a
to
7c00860
Compare
djaglowski
approved these changes
Oct 1, 2024
evan-bradley
approved these changes
Oct 2, 2024
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…ded (open-telemetry#35430) **Description:** <Describe what has changed.> If an empty config map is received, the supervisor does not run the agent. ~The current logic here works fine, but I'm considering adding an option to only do this if the user opts into it. I'm not sure if there's a reason why a user might want to run the collector with the noop config though (maybe for the agent's self-telemetry?)~ I've thought about it some more, and I don't think we need a config option here. If users want the collector to use a noop config, they can send a basic noop config. I think we should also implement open-telemetry#32598 (closed as stale, we'll want to re-open this or open a new issue for it), which would allow users to configure a backup config to use when no config is provided by the server, if they would like. **Link to tracking Issue:** Closes open-telemetry#33680 **Testing:** e2e test added Manually tested with a modified OpAMP server to send an empty config map **Documentation:** Update spec where it seemed applicable to call out this behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
If an empty config map is received, the supervisor does not run the agent.
The current logic here works fine, but I'm considering adding an option to only do this if the user opts into it. I'm not sure if there's a reason why a user might want to run the collector with the noop config though (maybe for the agent's self-telemetry?)I've thought about it some more, and I don't think we need a config option here. If users want the collector to use a noop config, they can send a basic noop config.
I think we should also implement #32598 (closed as stale, we'll want to re-open this or open a new issue for it), which would allow users to configure a backup config to use when no config is provided by the server, if they would like.
Link to tracking Issue: Closes #33680
Testing:
e2e test added
Manually tested with a modified OpAMP server to send an empty config map
Documentation:
Update spec where it seemed applicable to call out this behavior.