Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awsemfexporter: migrate to latest semconv version #35343

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

narcis96
Copy link
Contributor

Description: The version of semconv is upgraded from v1.6.1 to v1.27.0

This is a trivial migration. semconv usage inside component:

  • conventions.AttributeServiceName="service.name" on both versions
  • conventions.AttributeServiceNamespace="service.namespace" on both versions

Link to tracking Issue: #22095

Testing: Tests passed

@narcis96 narcis96 requested a review from a team as a code owner September 23, 2024 04:23
@github-actions github-actions bot added the exporter/awsemf awsemf exporter label Sep 23, 2024
@narcis96
Copy link
Contributor Author

I confirm there is no risk. The semconv attributes' value have been compared using go-otel-semconv-comparator resulting in 0 diffs.

@fatsheep9146

@crobert-1 crobert-1 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 24, 2024
@dmitryax dmitryax merged commit 683bb96 into open-telemetry:main Sep 24, 2024
162 of 163 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/awsemf awsemf exporter Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants