Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/ + pkg/ : migrate to latest semconv version #35241

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

narcis96
Copy link
Contributor

@narcis96 narcis96 commented Sep 17, 2024

Description: The version of semconv is upgraded to v1.27.0

The semconv attributes' value have been compared using go-otel-semconv-comparator resulting in 0 diffs:

  • 1.12.0 version has been used if the no newer version contains all attributes used by the file (all attributes of 1.6.1 exists and have the same value inside 1.12.0)
  • 1.27.0 version has been used if only if the file does not contain AttributeMessagingMessageID and AttributeMessagingKafkaMessageKey:

Link to tracking Issue: #22095

Testing: Tests passed

@narcis96 narcis96 requested a review from a team as a code owner September 24, 2024 11:30
@narcis96 narcis96 changed the title internal/ : migrate to latest semconv version internal/ + pkg/ : migrate to latest semconv version Sep 24, 2024
@crobert-1 crobert-1 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 24, 2024
@narcis96
Copy link
Contributor Author

PTAL
@dmitryax

@dashpole
@Aneurysm9
@sh0rez

@narcis96
Copy link
Contributor Author

narcis96 commented Oct 2, 2024

hey guys, can you please take a look ? @dmitryax @dashpole @Aneurysm9 @sh0rez

@mx-psi mx-psi merged commit 7fa8f92 into open-telemetry:main Oct 7, 2024
156 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 7, 2024
Eromosele-SM pushed a commit to sematext/opentelemetry-collector-contrib that referenced this pull request Oct 9, 2024
…35241)

Description: The version of semconv is upgraded to v1.27.0

The semconv attributes' value have been compared using
[go-otel-semconv-comparator](https://github.com/narcis96/go-otel-semconv-comparator)
resulting in 0 diffs:
- 1.12.0 version has been used if the no newer version contains all
attributes used by the file (all attributes of 1.6.1 exists and have the
same value inside 1.12.0)
- 1.27.0 version has been used if only if the file does not contain
AttributeMessagingMessageID and AttributeMessagingKafkaMessageKey:

Link to tracking Issue:
open-telemetry#22095

Testing: Tests passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants