-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/ + pkg/ : migrate to latest semconv version #35241
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichieSams
approved these changes
Sep 17, 2024
sh0rez
approved these changes
Sep 23, 2024
narcis96
force-pushed
the
narcis/internal
branch
from
September 24, 2024 11:30
743705a
to
74f8829
Compare
narcis96
changed the title
internal/ : migrate to latest semconv version
internal/ + pkg/ : migrate to latest semconv version
Sep 24, 2024
crobert-1
approved these changes
Sep 24, 2024
RichieSams
approved these changes
Sep 25, 2024
hey guys, can you please take a look ? @dmitryax @dashpole @Aneurysm9 @sh0rez |
mx-psi
approved these changes
Oct 2, 2024
Eromosele-SM
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Oct 9, 2024
…35241) Description: The version of semconv is upgraded to v1.27.0 The semconv attributes' value have been compared using [go-otel-semconv-comparator](https://github.com/narcis96/go-otel-semconv-comparator) resulting in 0 diffs: - 1.12.0 version has been used if the no newer version contains all attributes used by the file (all attributes of 1.6.1 exists and have the same value inside 1.12.0) - 1.27.0 version has been used if only if the file does not contain AttributeMessagingMessageID and AttributeMessagingKafkaMessageKey: Link to tracking Issue: open-telemetry#22095 Testing: Tests passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
internal/core
internal/exp/metrics
internal/filter
internal/metadataproviders
internal/splunk
pkg/translator/opencensus
Skip Changelog
PRs that do not require a CHANGELOG.md entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The version of semconv is upgraded to v1.27.0
The semconv attributes' value have been compared using go-otel-semconv-comparator resulting in 0 diffs:
Link to tracking Issue: #22095
Testing: Tests passed