[chore]: enable go-require rule from testifylint #35190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
force-pushed
the
testifylint/go-require
branch
from
45de8d0 to
55012ee
Compare
mmorel-35
force-pushed
the
testifylint/go-require
branch
from
55012ee to
bf6aedd
Compare
mmorel-35
force-pushed
the
testifylint/go-require
branch
from
bf6aedd to
56c755d
Compare
github-actions
bot
added
receiver/httpcheck
mmorel-35
force-pushed
the
testifylint/go-require
branch
from
56c755d to
6ad878a
Compare
github-actions
bot
added
connector/spanmetrics
exporter/carbon
exporter/datadog
mmorel-35
force-pushed
the
testifylint/go-require
branch
from
6ad878a to
b7435fa
Compare
mmorel-35
force-pushed
the
testifylint/go-require
branch
2 times, most recently
from
ef61ec6 to
e41af23
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
mmorel-35
force-pushed
the
testifylint/go-require
branch
from
e41af23 to
b0c491d
Compare
mmorel-35
requested review from
codeboten,
dashpole,
jmacd,
MovieStoreGuy,
yurishkuro,
atoulme,
dmitryax,
jpkrohling,
andrzej-stencel,
TylerHelmuth,
mx-psi and
songy23
as code owners
yurishkuro
reviewed
Sep 14, 2024
mx-psi
reviewed
Sep 16, 2024
|
Yes it is in the description of the PR see |
mx-psi
approved these changes
Sep 16, 2024
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
#### Description Testifylint is a linter that provides best practices with the use of testify. This PR enables [go-require](https://github.com/Antonboom/testifylint?tab=readme-ov-file#go-require) rule from [testifylint](https://github.com/Antonboom/testifylint) --------- Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testifylint is a linter that provides best practices with the use of testify.
This PR enables go-require rule from testifylint