Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore]: enable go-require rule from testifylint #35190

Merged
merged 2 commits into from
Sep 16, 2024
Merged

[chore]: enable go-require rule from testifylint #35190

merged 2 commits into from
Sep 16, 2024

Conversation

mmorel-35
Copy link
Contributor

Description

Testifylint is a linter that provides best practices with the use of testify.

This PR enables go-require rule from testifylint

@mmorel-35 mmorel-35 force-pushed the testifylint/go-require branch 2 times, most recently from ef61ec6 to e41af23 Compare September 14, 2024 14:01
@mmorel-35
[chore]: enable go-require rule from testifylint
b0c491d 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 marked this pull request as ready for review September 14, 2024 14:29
@mmorel-35 mmorel-35 requested a review from a team September 14, 2024 14:29
mx-psi
mx-psi reviewed Sep 16, 2024
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a link to the docs explaining what this rule does?

@mmorel-35
Copy link
Contributor Author

Yes it is in the description of the PR see
https://github.com/Antonboom/testifylint?tab=readme-ov-file#go-require

mx-psi
mx-psi approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 sorry, hadn't seen the link in the description. Just one more question, otherwise LGTM

.golangci.yml Outdated Show resolved Hide resolved
@mx-psi mx-psi merged commit bf19461 into open-telemetry:main Sep 16, 2024
155 of 156 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 16, 2024
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this pull request Oct 4, 2024
@mmorel-35 @jriguera
[chore]: enable go-require rule from testifylint (open-telemetry#35190)
3c2a004 
#### Description

Testifylint is a linter that provides best practices with the use of
testify.

This PR enables
[go-require](https://github.com/Antonboom/testifylint?tab=readme-ov-file#go-require)
rule from [testifylint](https://github.com/Antonboom/testifylint)

---------

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

@yurishkuro yurishkuro yurishkuro left review comments

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

@codeboten codeboten Awaiting requested review from codeboten codeboten is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@jmacd jmacd Awaiting requested review from jmacd jmacd is a code owner

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy MovieStoreGuy is a code owner

@atoulme atoulme Awaiting requested review from atoulme atoulme is a code owner

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel andrzej-stencel is a code owner

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth is a code owner

@songy23 songy23 Awaiting requested review from songy23 songy23 is a code owner

Assignees

@mx-psi mx-psi

Labels
cmd/telemetrygen telemetrygen command connector/spanmetrics exporter/carbon exporter/datadog Datadog components exporter/honeycombmarker exporter/loadbalancing exporter/loki Loki Exporter exporter/opensearch exporter/otelarrow exporter/prometheus exporter/sapm exporter/splunkhec exporter/sumologic exporter/syslog extension/jaegerremotesampling extension/sumologic internal/core internal/docker internal/kubelet internal/otelarrow pkg/stanza processor/resourcedetection Resource detection processor processor/tailsampling Tail sampling processor receiver/apache receiver/apachespark receiver/bigip receiver/couchdb receiver/elasticsearch receiver/expvar receiver/flinkmetrics receiver/fluentforward receiver/haproxy receiver/httpcheck HTTP Check receiver receiver/jaeger receiver/kafka receiver/nginx receiver/nsxt NSXT Receiver receiver/otelarrow receiver/prometheus Prometheus receiver receiver/rabbitmq receiver/riak receiver/sshcheck receiver/vcenter receiver/zookeeper
Projects
None yet
Milestone
v0.110.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mmorel-35 @yurishkuro @mx-psi