[chore]: enable expected-actual rule from testifylint #34998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cmd/telemetrygen
mmorel-35
requested review from
jpkrohling,
codeboten,
mx-psi,
bogdandrutu,
evan-bradley,
fatsheep9146,
mwear,
jsuereth,
songy23 and
bryan-aguilar
as code owners
songy23
approved these changes
Sep 4, 2024
mmorel-35
force-pushed
the
testifylint/expected-actual
branch
from
e82890c
to
4110ffb
Compare
|
#35007 is open for the failing fileconsumer tests, I believe the failures are unrelated to this change. |
crobert-1
approved these changes
Sep 4, 2024
mmorel-35
force-pushed
the
testifylint/expected-actual
branch
2 times, most recently
from
2d2a20d
to
26ff901
Compare
mmorel-35
force-pushed
the
testifylint/expected-actual
branch
2 times, most recently
from
49cad1e
to
ade0584
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
mmorel-35
force-pushed
the
testifylint/expected-actual
branch
from
ade0584
to
fce1dfb
Compare
songy23
added
the
ready to merge
codeboten
approved these changes
Sep 5, 2024
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
…#34998) #### Description Testifylint is a linter that provides best practices with the use of testify. This PR enables [expected-actual](https://github.com/Antonboom/testifylint?tab=readme-ov-file#expected-actual) rule from [testifylint](https://github.com/Antonboom/testifylint) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testifylint is a linter that provides best practices with the use of testify.
This PR enables expected-actual rule from testifylint