[chore]: enable error-is-as rule from testifylint #34995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
requested review from
jpkrohling,
jmacd,
crobert-1 and
dmitryax
as code owners
github-actions
bot
requested review from
frzifus,
kentquirk,
lquerel,
moh-osman3,
rmfitzpatrick,
rnishtala-sumo,
srprash and
wangzlei
mmorel-35
force-pushed
the
testifylint/error-is-as
branch
from
d36b4d7
to
35ef572
Compare
MovieStoreGuy
approved these changes
Sep 4, 2024
frzifus
approved these changes
Sep 4, 2024
mmorel-35
force-pushed
the
testifylint/error-is-as
branch
from
35ef572
to
ff6e966
Compare
mmorel-35
force-pushed
the
testifylint/error-is-as
branch
from
ff6e966
to
d2ef934
Compare
crobert-1
approved these changes
Sep 4, 2024
songy23
added
the
ready to merge
mmorel-35
force-pushed
the
testifylint/error-is-as
branch
2 times, most recently
from
6b14793
to
6603893
Compare
mmorel-35
force-pushed
the
testifylint/error-is-as
branch
from
6603893
to
e522a4c
Compare
codeboten
reviewed
Sep 4, 2024
codeboten
reviewed
Sep 4, 2024
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
mmorel-35
force-pushed
the
testifylint/error-is-as
branch
from
8ce125e
to
1b76e32
Compare
codeboten
approved these changes
Sep 5, 2024
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
#### Description Testifylint is a linter that provides best practices with the use of testify. This PR enables [error-is-as](https://github.com/Antonboom/testifylint?tab=readme-ov-file#error-is-as) rule from [testifylint](https://github.com/Antonboom/testifylint) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testifylint is a linter that provides best practices with the use of testify.
This PR enables error-is-as rule from testifylint