[processor/resourcedetection] support for periodically do detect action #34959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
processor/resourcedetection
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
JaredTan95
force-pushed
the
periodically-do-detect-action
branch
from
119238e
to
f02b220
Compare
atoulme
reviewed
Sep 4, 2024
| defer intervalTicker.Stop() | ||
|
|
||
| var err error | ||
| for range intervalTicker.C { |
There was a problem hiding this comment.
This is an infinite loop that receives the timer's signal through the intervalTicker.C channel. Whenever the timer fires, the channel intervalTicker.C sends a time value.
Therefore, as long as the otel process does not exit, it will continue to execute periodically.
Do we need to add a flag so that users can configure when to exit?
atoulme
reviewed
Sep 4, 2024
| rdp.resource, rdp.schemaURL, err = rdp.provider.Get(ctx, client) | ||
|
|
||
| if rdp.detectInterval > 0 { | ||
| go rdp.tickerDetect(ctx, client) |
There was a problem hiding this comment.
please make sure stop closes this coroutine to avoid leaks
atoulme
reviewed
Sep 4, 2024
| component: resourcedetectionprocessor | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: support for periodically do detect action. |
There was a problem hiding this comment.
Suggested change
| note: support for periodically do detect action. | |
| note: add support to refreshing the resource provider performing detection. |
atoulme
reviewed
Sep 4, 2024
|
|
||
| var err error | ||
| for range intervalTicker.C { | ||
| rdp.resource, rdp.schemaURL, err = rdp.provider.Get(ctx, client) |
There was a problem hiding this comment.
is it safe to reassign without locks?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: support for periodically do detect action
Link to tracking Issue: <#34876>
Testing:
Documentation: