[processor/resourcedetection] support for periodically do detect action #34959
Conversation
github-actions
bot
added
the
processor/resourcedetection
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
JaredTan95
force-pushed
the
periodically-do-detect-action
branch
from
119238e
to
f02b220
Compare
| defer intervalTicker.Stop() | ||
|
|
||
| var err error | ||
| for range intervalTicker.C { |
There was a problem hiding this comment.
This is an infinite loop that receives the timer's signal through the intervalTicker.C channel. Whenever the timer fires, the channel intervalTicker.C sends a time value.
Therefore, as long as the otel process does not exit, it will continue to execute periodically.
Do we need to add a flag so that users can configure when to exit?
| rdp.resource, rdp.schemaURL, err = rdp.provider.Get(ctx, client) | ||
|
|
||
| if rdp.detectInterval > 0 { | ||
| go rdp.tickerDetect(ctx, client) |
There was a problem hiding this comment.
please make sure stop closes this coroutine to avoid leaks
| component: resourcedetectionprocessor | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: support for periodically do detect action. |
There was a problem hiding this comment.
| note: support for periodically do detect action. | |
| note: add support to refreshing the resource provider performing detection. |
|
|
||
| var err error | ||
| for range intervalTicker.C { | ||
| rdp.resource, rdp.schemaURL, err = rdp.provider.Get(ctx, client) |
There was a problem hiding this comment.
is it safe to reassign without locks?
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Description: support for periodically do detect action
Link to tracking Issue: <#34876>
Testing:
Documentation: