-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/awscontainerinsightreceiver] Add support for controller-name use with StatefulSet #34901
Conversation
Please add changelog and a test. See my review comments as well. Thanks for the contribution! |
@atoulme I think I have addressed all the feedback - please let me know if anything else is required! |
Hi @atoulme any chance of a re-review of this PR and getting it merged in? |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Hey @atoulme would be great if this could be looked at - it's something we need internally so if this isn't going to be merged then I will likely start exploring how to maintain a fork. Would obviously prefer to avoid that though! |
@atoulme if this is just not going to be looked at or considered it would be great if yourself or another maintainer could let me know please! |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Sorry - looks good to me. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Description:
Implemented the feature in the linked issue.
Link to tracking Issue: #33507
Testing: None yet - wanted some feedback on if this direction would work.
Documentation: None yet.