Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/awscontainerinsightreceiver] Add support for controller-name use with StatefulSet #34901

Closed
wants to merge 6 commits into from

Conversation

jbeemster
Copy link

Description:

Implemented the feature in the linked issue.

Link to tracking Issue: #33507

Testing: None yet - wanted some feedback on if this direction would work.

Documentation: None yet.

@jbeemster jbeemster requested review from a team and djaglowski August 28, 2024 09:46
Copy link

linux-foundation-easycla bot commented Aug 28, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@atoulme
Copy link
Contributor

atoulme commented Sep 4, 2024

Please add changelog and a test. See my review comments as well. Thanks for the contribution!

@jbeemster jbeemster changed the title Add support for controller-name use with StatefulSet [receiver/awscontainerinsightreceiver] Add support for controller-name use with StatefulSet Sep 5, 2024
@jbeemster
Copy link
Author

@atoulme I think I have addressed all the feedback - please let me know if anything else is required!

@jbeemster jbeemster requested a review from atoulme September 5, 2024 15:29
@jbeemster
Copy link
Author

Hi @atoulme any chance of a re-review of this PR and getting it merged in?

Copy link
Contributor

github-actions bot commented Oct 9, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 9, 2024
@jbeemster
Copy link
Author

Hey @atoulme would be great if this could be looked at - it's something we need internally so if this isn't going to be merged then I will likely start exploring how to maintain a fork. Would obviously prefer to avoid that though!

@jbeemster
Copy link
Author

@atoulme if this is just not going to be looked at or considered it would be great if yourself or another maintainer could let me know please!

Copy link
Contributor

github-actions bot commented Nov 6, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 6, 2024
@atoulme atoulme requested a review from a team as a code owner November 9, 2024 05:42
@atoulme
Copy link
Contributor

atoulme commented Nov 9, 2024

Sorry - looks good to me.

@github-actions github-actions bot removed the Stale label Nov 10, 2024
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 24, 2024
Copy link
Contributor

github-actions bot commented Dec 8, 2024

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants