-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] remove generated code #34844
Merged
andrzej-stencel
merged 1 commit into
open-telemetry:main
from
dynatrace-oss-contrib:remove-gen-code
Oct 3, 2024
Merged
[chore] remove generated code #34844
andrzej-stencel
merged 1 commit into
open-telemetry:main
from
dynatrace-oss-contrib:remove-gen-code
Oct 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mowies
changed the title
[chore] remove generated code
[WIP] [chore] remove generated code
Aug 26, 2024
mowies
force-pushed
the
remove-gen-code
branch
4 times, most recently
from
August 28, 2024 06:26
a5532ae
to
75fb19c
Compare
mowies
force-pushed
the
remove-gen-code
branch
from
August 28, 2024 08:19
e076ab6
to
033e9e0
Compare
mowies
force-pushed
the
remove-gen-code
branch
2 times, most recently
from
September 2, 2024 09:54
f368d0e
to
68d5543
Compare
atoulme
approved these changes
Sep 10, 2024
mowies
force-pushed
the
remove-gen-code
branch
from
September 17, 2024 09:46
68d5543
to
fd77587
Compare
mowies
changed the title
[WIP] [chore] remove generated code
[chore] remove generated code
Sep 17, 2024
mowies
force-pushed
the
remove-gen-code
branch
2 times, most recently
from
September 19, 2024 09:20
e102003
to
0ab80f1
Compare
mowies
force-pushed
the
remove-gen-code
branch
2 times, most recently
from
September 30, 2024 09:18
6559de7
to
c255bca
Compare
mowies
force-pushed
the
remove-gen-code
branch
2 times, most recently
from
October 3, 2024 06:46
9189d28
to
2d2050c
Compare
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
mowies
force-pushed
the
remove-gen-code
branch
from
October 3, 2024 06:47
2d2050c
to
b84d297
Compare
andrzej-stencel
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
evan-bradley
added a commit
that referenced
this pull request
Oct 3, 2024
**Description:** Follow up to #34844. It looks like a few more workflows need `make genotelcontribcol`.
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This PR: - removes all of the auto generated files in cmd/otelcontribcol and cmd/oteltestbedcol - left some files in place to support the setup, e.g. Dockerfile, metadata.yaml files, builder-config.yaml files - adds gitignore files in the folders in question to prevent committing of auto-generated files - adds the tools folder to all actions/cache pipeline steps since there were some caching issues that came up during development of this PR - adds make generate commands to place where the auto-generated code files are needed **Link to tracking Issue:** Fixes open-telemetry#27850 Fixes open-telemetry#30884 Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
**Description:** Follow up to open-telemetry#34844. It looks like a few more workflows need `make genotelcontribcol`.
Eromosele-SM
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Oct 9, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This PR: - removes all of the auto generated files in cmd/otelcontribcol and cmd/oteltestbedcol - left some files in place to support the setup, e.g. Dockerfile, metadata.yaml files, builder-config.yaml files - adds gitignore files in the folders in question to prevent committing of auto-generated files - adds the tools folder to all actions/cache pipeline steps since there were some caching issues that came up during development of this PR - adds make generate commands to place where the auto-generated code files are needed **Link to tracking Issue:** Fixes open-telemetry#27850 Fixes open-telemetry#30884 Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Eromosele-SM
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Oct 9, 2024
**Description:** Follow up to open-telemetry#34844. It looks like a few more workflows need `make genotelcontribcol`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cmd/otelcontribcol
otelcontribcol command
cmd/oteltestbedcol
cmd/telemetrygen
telemetrygen command
internal/tools
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR:
Link to tracking Issue:
Fixes #27850
Fixes #30884