Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] remove generated code #34844

Merged

Conversation

mowies
Copy link
Member

@mowies mowies commented Aug 26, 2024

Description:

This PR:

  • removes all of the auto generated files in cmd/otelcontribcol and cmd/oteltestbedcol
  • left some files in place to support the setup, e.g. Dockerfile, metadata.yaml files, builder-config.yaml files
  • adds gitignore files in the folders in question to prevent committing of auto-generated files
  • adds the tools folder to all actions/cache pipeline steps since there were some caching issues that came up during development of this PR
  • adds make generate commands to place where the auto-generated code files are needed

Link to tracking Issue:
Fixes #27850
Fixes #30884

@github-actions github-actions bot added the cmd/otelcontribcol otelcontribcol command label Aug 26, 2024
@mowies mowies changed the title [chore] remove generated code [WIP] [chore] remove generated code Aug 26, 2024
@mowies mowies force-pushed the remove-gen-code branch 4 times, most recently from a5532ae to 75fb19c Compare August 28, 2024 06:26
@github-actions github-actions bot added the cmd/telemetrygen telemetrygen command label Aug 28, 2024
@mowies mowies force-pushed the remove-gen-code branch 2 times, most recently from f368d0e to 68d5543 Compare September 2, 2024 09:54
@mowies mowies marked this pull request as ready for review September 17, 2024 10:06
@mowies mowies requested a review from a team September 17, 2024 10:06
@mowies mowies changed the title [WIP] [chore] remove generated code [chore] remove generated code Sep 17, 2024
@mowies mowies force-pushed the remove-gen-code branch 2 times, most recently from e102003 to 0ab80f1 Compare September 19, 2024 09:20
@mowies mowies requested a review from a team as a code owner September 19, 2024 09:20
@mowies mowies force-pushed the remove-gen-code branch 2 times, most recently from 6559de7 to c255bca Compare September 30, 2024 09:18
@mowies mowies force-pushed the remove-gen-code branch 2 times, most recently from 9189d28 to 2d2050c Compare October 3, 2024 06:46
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Copy link
Member

@andrzej-stencel andrzej-stencel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to align with what was defined in #27850. Thank you @mowies!

@andrzej-stencel andrzej-stencel merged commit 30fc917 into open-telemetry:main Oct 3, 2024
156 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 3, 2024
@mowies mowies deleted the remove-gen-code branch October 3, 2024 11:23
evan-bradley added a commit that referenced this pull request Oct 3, 2024
**Description:**

Follow up to
#34844.
It looks like a few more workflows need `make genotelcontribcol`.
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this pull request Oct 4, 2024
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
This PR:
- removes all of the auto generated files in cmd/otelcontribcol and
cmd/oteltestbedcol
- left some files in place to support the setup, e.g. Dockerfile,
metadata.yaml files, builder-config.yaml files
- adds gitignore files in the folders in question to prevent committing
of auto-generated files
- adds the tools folder to all actions/cache pipeline steps since there
were some caching issues that came up during development of this PR
- adds make generate commands to place where the auto-generated code
files are needed

**Link to tracking Issue:**
Fixes
open-telemetry#27850
Fixes open-telemetry#30884

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this pull request Oct 4, 2024
**Description:**

Follow up to
open-telemetry#34844.
It looks like a few more workflows need `make genotelcontribcol`.
Eromosele-SM pushed a commit to sematext/opentelemetry-collector-contrib that referenced this pull request Oct 9, 2024
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
This PR:
- removes all of the auto generated files in cmd/otelcontribcol and
cmd/oteltestbedcol
- left some files in place to support the setup, e.g. Dockerfile,
metadata.yaml files, builder-config.yaml files
- adds gitignore files in the folders in question to prevent committing
of auto-generated files
- adds the tools folder to all actions/cache pipeline steps since there
were some caching issues that came up during development of this PR
- adds make generate commands to place where the auto-generated code
files are needed

**Link to tracking Issue:**
Fixes
open-telemetry#27850
Fixes open-telemetry#30884

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Eromosele-SM pushed a commit to sematext/opentelemetry-collector-contrib that referenced this pull request Oct 9, 2024
**Description:**

Follow up to
open-telemetry#34844.
It looks like a few more workflows need `make genotelcontribcol`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove tests from cmd/otelcontribcol Remove generated code from cmd/otecontribcol or cmd/otetestbedcol
4 participants