-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/elasticsearch] Add span event to traces OTel mapping mode #34831
Merged
andrzej-stencel
merged 4 commits into
open-telemetry:main
from
carsonip:otel-mode-traces-independent-events-pr
Sep 5, 2024
Merged
[exporter/elasticsearch] Add span event to traces OTel mapping mode #34831
andrzej-stencel
merged 4 commits into
open-telemetry:main
from
carsonip:otel-mode-traces-independent-events-pr
Sep 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonip
force-pushed
the
otel-mode-traces-independent-events-pr
branch
from
August 30, 2024 10:05
c66b028
to
b95c372
Compare
carsonip
force-pushed
the
otel-mode-traces-independent-events-pr
branch
from
August 30, 2024 11:11
5d2859f
to
001999c
Compare
crobert-1
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic looks good to me. Since there's no open issue for this that I'm aware of, I'll defer to code owners to confirm this behavior aligns with the goals of this component 👍
felixbarny
approved these changes
Sep 5, 2024
andrzej-stencel
approved these changes
Sep 5, 2024
andrzej-stencel
added
the
ready to merge
Code review completed; ready to merge by maintainers
label
Sep 5, 2024
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
…pen-telemetry#34831) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Span events are now supported in OTel mapping mode. They will be routed to `logs-${data_stream.dataset}-${data_stream.namespace}` if `traces_dynamic_index::enabled` is `true`. **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> Updated exporter tests **Documentation:** <Describe the documentation added.>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Span events are now supported in OTel mapping mode.
They will be routed to
logs-${data_stream.dataset}-${data_stream.namespace}
iftraces_dynamic_index::enabled
istrue
.Link to tracking Issue:
Testing:
Updated exporter tests
Documentation: