Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTel-Arrow exporter timeout propagation #34733

Merged
merged 17 commits into from
Sep 5, 2024
Merged

OTel-Arrow exporter timeout propagation #34733

merged 17 commits into from
Sep 5, 2024

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Aug 19, 2024 •
edited
Loading

Description: Exporter side of open-telemetry/otel-arrow#227. The receiver side is #34742.

Link to tracking Issue: open-telemetry/otel-arrow#227

Testing: Adds a test for the expected metadata propagation.

Documentation: Since this is expected of gRPC receivers, no docs are changed.

@jmacd jmacd requested review from a team and songy23 August 19, 2024 16:50
@github-actions github-actions bot requested review from lquerel and moh-osman3 August 19, 2024 16:50
@jmacd jmacd mentioned this pull request Aug 19, 2024
Merged
moh-osman3
moh-osman3 approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@moh-osman3 moh-osman3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwear mwear added the ready to merge Code review completed; ready to merge by maintainers label Aug 21, 2024
@github-actions github-actions bot mentioned this pull request Aug 27, 2024
Closed
@jmacd
Copy link
Contributor Author

jmacd commented Aug 30, 2024

This has been approved for 2 weeks. Can it merge?

@github-actions github-actions bot mentioned this pull request Sep 3, 2024
Closed
@MovieStoreGuy
Copy link
Contributor

This has been approved for 2 weeks. Can it merge?

Can I ask you to fix up the merge conflicts please?

@jmacd
Copy link
Contributor Author

jmacd commented Sep 4, 2024

Can I ask you to fix up the merge conflicts please?

Of course! I fix the conflicts after every release, but this has been sitting for two release cycles and now I'll have to fix them twice.

@jmacd
Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec…
128530e 
…tor-contrib into jmacd/arrow_exporter_timeout
@songy23 songy23 removed the ready to merge Code review completed; ready to merge by maintainers label Sep 4, 2024
songy23
songy23 reviewed Sep 4, 2024
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace statements are out of date, please run "make crosslink" and commit the changes in this PR.

Please fix linter as well https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10704184781/job/29676638560?pr=34733

@jmacd
Copy link
Contributor Author

jmacd commented Sep 5, 2024

@songy23 Thank you. I appreciate your help. The linter changed while this PR was open,.

I want to point out that this PR was approved and green following commit f735180 and again following commit 9e4d8e3. It takes a relatively large amount of work to keep these PRs green, and this is the third time. Please merge!

songy23
songy23 approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @open-telemetry/collector-contrib-maintainers this one should be good to go

@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Sep 5, 2024
@codeboten codeboten merged commit 6eaf284 into open-telemetry:main Sep 5, 2024
163 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 5, 2024
f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this pull request Sep 12, 2024
@jmacd @f7o
OTel-Arrow exporter timeout propagation (open-telemetry#34733)
0480119 
**Description:** Exporter side of
open-telemetry/otel-arrow#227. The receiver
side is
open-telemetry#34742.

**Link to tracking Issue:**
open-telemetry/otel-arrow#227

**Testing:** Adds a test for the expected metadata propagation.

**Documentation:** Since this is expected of gRPC receivers, no docs are
changed.
codeboten added a commit that referenced this pull request Sep 23, 2024
@jmacd @bogdandrutu @codeboten
OTel-Arrow receiver timeout propagation (#34742)
23083a5 
**Description:** Receiver side of
open-telemetry/otel-arrow#227. The exporter
side is
#34733.
 
**Link to tracking Issue:**
open-telemetry/otel-arrow#227

**Testing:** A new end-to-end integration test. ✅ 

**Documentation:** Since this is expected of gRPC receivers, no docs are
changed.

---------

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this pull request Oct 4, 2024
@jmacd @bogdandrutu
@codeboten @jriguera
OTel-Arrow receiver timeout propagation (open-telemetry#34742)
4e6df20 
**Description:** Receiver side of
open-telemetry/otel-arrow#227. The exporter
side is
open-telemetry#34733.
 
**Link to tracking Issue:**
open-telemetry/otel-arrow#227

**Testing:** A new end-to-end integration test. ✅ 

**Documentation:** Since this is expected of gRPC receivers, no docs are
changed.

---------

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moh-osman3 moh-osman3 moh-osman3 approved these changes

@songy23 songy23 songy23 approved these changes

@mwear mwear mwear approved these changes

@codeboten codeboten codeboten approved these changes

@lquerel lquerel Awaiting requested review from lquerel

Assignees

@andrzej-stencel andrzej-stencel

Labels
cmd/otelcontribcol otelcontribcol command exporter/otelarrow internal/otelarrow ready to merge Code review completed; ready to merge by maintainers receiver/otelarrow
Projects
None yet
Milestone
v0.109.0
Development

Successfully merging this pull request may close these issues.
7 participants
@jmacd @MovieStoreGuy @codeboten @mwear @songy23 @moh-osman3 @andrzej-stencel