add interval to experimental entity events #34241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
braydonk,
dmitryax,
rmfitzpatrick and
TylerHelmuth
povilasv
force-pushed
the
entity-interval
branch
3 times, most recently
from
8d92993
to
43988d1
Compare
tigrannajaryan
approved these changes
Jul 25, 2024
| @@ -18,6 +20,7 @@ const ( | |||
|
|
|||
| semconvOtelEntityID = "otel.entity.id" | |||
| semconvOtelEntityType = "otel.entity.type" | |||
| semconvOtelEntityInterval = "otel.entity.interval" | |||
There was a problem hiding this comment.
Please also update the design doc here to keep up to date: https://docs.google.com/document/d/1Tg18sIck3Nakxtd3TFFcIjrmRO_0GLMdHXylVqBQmJA/edit#heading=h.1kzy7lkx5qw1
povilasv
force-pushed
the
entity-interval
branch
from
43988d1
to
dba3f27
Compare
dmitryax
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding reporting interval to entity events.
Link to tracking Issue:
#34240
Testing:
Documentation: