-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore][connector/spanmetrics]: replace github.com/tilinna/clock
with github.com/jonboulle/clockwork
#34226
Merged
djaglowski
merged 5 commits into
open-telemetry:main
from
odubajDT:clock-spanmetricsconnector
Jul 24, 2024
Merged
[chore][connector/spanmetrics]: replace github.com/tilinna/clock
with github.com/jonboulle/clockwork
#34226
djaglowski
merged 5 commits into
open-telemetry:main
from
odubajDT:clock-spanmetricsconnector
Jul 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cmd/otelcontribcol
otelcontribcol command
connector/spanmetrics
exporter/elasticsearch
testbed
labels
Jul 23, 2024
github-actions
bot
requested review from
carsonip,
Frapschen,
JaredTan95,
portertech and
ycombinator
July 23, 2024 11:53
djaglowski
pushed a commit
that referenced
this pull request
Jul 23, 2024
…/clock` with `github.com/jonboulle/clockwork` (#34224) **Description:** - replaces `github.com/tilinna/clock` with `github.com/jonboulle/clockwork` in `jaegerremotesampleing extension` **Link to tracking Issue:** #34190 **Connected PRs:** - #34221 - #34226 --------- Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
djaglowski
approved these changes
Jul 23, 2024
djaglowski
pushed a commit
that referenced
this pull request
Jul 23, 2024
…thub.com/jonboulle/clockwork` (#34221) **Description:** - replaces `github.com/tilinna/clock` with `github.com/jonboulle/clockwork` in `chrony receiver` **Link to tracking Issue:** #34190 **Connected PRs:** - #34224 - #34226 **Notes:** The failing check is not caused by changes in this PR, it's a flaky test #33865 --------- Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
ChrsMark
approved these changes
Jul 23, 2024
crobert-1
approved these changes
Jul 23, 2024
crobert-1
added
the
ready to merge
Code review completed; ready to merge by maintainers
label
Jul 23, 2024
|
… github.com/jonboulle/clockwork Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
odubajDT
force-pushed
the
clock-spanmetricsconnector
branch
from
July 24, 2024 06:02
b992980
to
13bacb7
Compare
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
odubajDT
force-pushed
the
clock-spanmetricsconnector
branch
from
July 24, 2024 06:40
13bacb7
to
e14c974
Compare
odubajDT
commented
Jul 24, 2024
djaglowski
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @odubajDT!
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cmd/otelcontribcol
otelcontribcol command
connector/spanmetrics
exporter/elasticsearch
ready to merge
Code review completed; ready to merge by maintainers
testbed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
github.com/tilinna/clock
withgithub.com/jonboulle/clockwork
inspanmetrics connector
Link to tracking Issue: #34190
Connected PRs:
github.com/tilinna/clock
withgithub.com/jonboulle/clockwork
#34221github.com/tilinna/clock
withgithub.com/jonboulle/clockwork
#34224