Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][connector/spanmetrics]: replace github.com/tilinna/clock with github.com/jonboulle/clockwork #34226

Merged
merged 5 commits into from
Jul 24, 2024

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Jul 23, 2024

Description:

  • replaces github.com/tilinna/clock with github.com/jonboulle/clockwork in spanmetrics connector

Link to tracking Issue: #34190

Connected PRs:

@odubajDT odubajDT marked this pull request as ready for review July 23, 2024 13:25
@odubajDT odubajDT requested review from a team and bryan-aguilar July 23, 2024 13:25
djaglowski pushed a commit that referenced this pull request Jul 23, 2024
…/clock` with `github.com/jonboulle/clockwork` (#34224)

**Description:**
- replaces `github.com/tilinna/clock` with
`github.com/jonboulle/clockwork` in `jaegerremotesampleing extension`

**Link to tracking Issue:**
#34190

**Connected PRs:**
-
#34221
-
#34226

---------

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
djaglowski pushed a commit that referenced this pull request Jul 23, 2024
…thub.com/jonboulle/clockwork` (#34221)

**Description:**
- replaces `github.com/tilinna/clock` with
`github.com/jonboulle/clockwork` in `chrony receiver`

**Link to tracking Issue:**
#34190

**Connected PRs:**
-
#34224
-
#34226

**Notes:**

The failing check is not caused by changes in this PR, it's a flaky test
#33865

---------

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@crobert-1 crobert-1 added the ready to merge Code review completed; ready to merge by maintainers label Jul 23, 2024
@djaglowski
Copy link
Member

please run "make genotelcontribcol" and commit the changes in this PR

… github.com/jonboulle/clockwork

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
cmd/otelcontribcol/go.mod Outdated Show resolved Hide resolved
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @odubajDT!

@djaglowski djaglowski merged commit d5c40d3 into open-telemetry:main Jul 24, 2024
154 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/otelcontribcol otelcontribcol command connector/spanmetrics exporter/elasticsearch ready to merge Code review completed; ready to merge by maintainers testbed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants