[exporter/clickhouse] Remove deprecated ttl_days config option
#33648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpencerTorres
approved these changes
Jun 19, 2024
codeboten
approved these changes
Jun 19, 2024
codeboten
reviewed
Jun 19, 2024
.chloggen/clickhouseexporter-remove-deprecated-config-option.yaml
Outdated
Show resolved
Hide resolved
`ttl_days` has been deprecated since 0.90.0. `ttl` config option should be used instead.
dmitryax
force-pushed
the
clickhouse-exporter-remove-deprecated-config-option
branch
from
30fad1b
to
bdc3f88
Compare
andrzej-stencel
pushed a commit
that referenced
this pull request
Jul 3, 2024
…33615) **Description:** *NOTE: Depends on merging of #33611, #33614, and #33648* Logs configuration is unlikely to change further with the new recommendation of [manual schema config](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/exporter/clickhouseexporter#schema-management). The logs component of the exporter has proven stability, as seen in deployments such as [ClickHouse's Loghouse](https://clickhouse.com/blog/building-a-logging-platform-with-clickhouse-and-saving-millions-over-datadog). With these points in mind, I suggest we upgrade the status to `beta` for logs. Traces and metrics can remain `alpha` for now. **Documentation:** - Updated metadata.yaml - Updated README - Small unrelated change: added/refactored a section that covers tool visualization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ttl_dayshas been deprecated since 0.90.0.ttlconfig option should be used instead.