-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processor/geoip] Add maxmind geoprovider #33451
[processor/geoip] Add maxmind geoprovider #33451
Conversation
processor/geoipprocessor/internal/provider/maxmindprovider/config.go
Outdated
Show resolved
Hide resolved
processor/geoipprocessor/go.mod
Outdated
require ( | ||
github.com/maxmind/mmdbwriter v1.0.0 // indirect | ||
go4.org/netipx v0.0.0-20230824141953-6213f710f925 // indirect | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this a separate set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure, it was automatically added by my editor's formatter (maybe when working from a go.mod subdirectory?). Require blocks unified in 05458bf
processor/geoipprocessor/internal/provider/maxmindprovider/config.go
Outdated
Show resolved
Hide resolved
instead of using geoip_database_path
processor/geoipprocessor/internal/provider/maxmindprovider/provider.go
Outdated
Show resolved
Hide resolved
The variable is used to define the language code.
@andrzej-stencel @fatsheep9146 I wanted to check in regarding this PR. If there’s anything specific you need from me before reviewing, please let me know. Thank you in advance! |
Description: This PR adds an initial implementation for the MaxMind GeoIP provider for later usage in the
geoipprocessor
. The processor is still a nop, as no provider can be configured yet. Providers configuration will be added in #33268.processor/geoipprocessor/internal/convention/attributes.go
Link to tracking Issue: #32663
Testing: Database files are generated before running the unit tests using MaxMind writer.. The generation time of those files seems not to be an issue (0.189s):
Testing database files are removed on sucessful test execution.
Documentation: README.md file