[processor/transform] introduce aggregate_on_attribute_value function for metrics #33423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bogdandrutu,
evan-bradley,
kentquirk and
TylerHelmuth
odubajDT
force-pushed
the
feat/16224/aggregate-label-value
branch
from
c20b2b5
to
02b67f3
Compare
odubajDT
changed the title
evan-bradley
pushed a commit
that referenced
this pull request
Jul 2, 2024
**Description:** <Describe what has changed.> - duplicated and enhanced aggregation business logic (with median function) for common usage in follow-up tickets - tests **Link to tracking Issue:** #16224 **Follow-ups:** - #33655 - #33334 - #33423 --------- Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
odubajDT
force-pushed
the
feat/16224/aggregate-label-value
branch
2 times, most recently
from
4efaef2
to
f1695ae
Compare
odubajDT
force-pushed
the
feat/16224/aggregate-label-value
branch
2 times, most recently
from
4b42a51
to
eaec68c
Compare
odubajDT
force-pushed
the
feat/16224/aggregate-label-value
branch
4 times, most recently
from
8339c0c
to
2d876ab
Compare
odubajDT
force-pushed
the
feat/16224/aggregate-label-value
branch
2 times, most recently
from
26060ce
to
6751508
Compare
odubajDT
force-pushed
the
feat/16224/aggregate-label-value
branch
from
19e0b2f
to
97f8f68
Compare
odubajDT
commented
Aug 7, 2024
odubajDT
force-pushed
the
feat/16224/aggregate-label-value
branch
from
0ca7ae3
to
01fc697
Compare
|
Hey @TylerHelmuth @evan-bradley would you please have a look? |
alecrajeev
reviewed
Aug 24, 2024
odubajDT
commented
Aug 26, 2024
|
@TylerHelmuth @evan-bradley would you have time to look into this? Thanks! |
MovieStoreGuy
approved these changes
Sep 2, 2024
Just doubling checking with code owners before it is merged. |
evan-bradley
reviewed
Sep 4, 2024
processor/transformprocessor/internal/metrics/func_agregate_on_attribute_value_metrics.go
Outdated
Show resolved
Hide resolved
processor/transformprocessor/internal/metrics/func_agregate_on_attribute_value_metrics_test.go
Show resolved
Hide resolved
processor/transformprocessor/internal/metrics/func_agregate_on_attribute_value_metrics_test.go
Show resolved
Hide resolved
… for metrics Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
odubajDT
force-pushed
the
feat/16224/aggregate-label-value
branch
from
e4c5cbe
to
54dfc96
Compare
|
Hey @evan-bradley, just double checking you're okay with the changes made? |
evan-bradley
approved these changes
Sep 5, 2024
|
This looks good to me, thanks for continuing to push this along @MovieStoreGuy. @TylerHelmuth could you take a look when you have time? |
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
TylerHelmuth
approved these changes
Sep 6, 2024
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
… for metrics (open-telemetry#33423) **Link to tracking Issue:** open-telemetry#16224 **Changes:** - implemented `aggregate_on_attribute_value` function - tests - documentation **Depends on** open-telemetry#33669 --------- Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to tracking Issue: #16224
Changes:
aggregate_on_attribute_valuefunctionDepends on #33669