Promote rabbitmqexporter to alpha #33331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cmd/otelcontribcol
swar8080
force-pushed
the
rabbitmqexporter-alpha-promotion
branch
3 times, most recently
from
17d09a0
to
bc110df
Compare
|
Should this be a draft PR based on the title? If so, can you mark it as draft using the link below the reviewers list? |
swar8080
force-pushed
the
rabbitmqexporter-alpha-promotion
branch
from
1a888d5
to
890cc7c
Compare
swar8080
changed the title
fatsheep9146
approved these changes
Jun 9, 2024
There was a problem hiding this comment.
LGTM!
BTW, I think https://github.com/open-telemetry/opentelemetry-collector-releases/blob/main/distributions/otelcol-contrib/manifest.yaml should also be updated.
songy23
added
the
ready to merge
swar8080
force-pushed
the
rabbitmqexporter-alpha-promotion
branch
from
1511ef2
to
8e2b057
Compare
This was referenced Jun 19, 2024
This was referenced Jun 20, 2024
|
Hi @atoulme, this seems ready to merge once you approve |
atoulme
approved these changes
Jun 29, 2024
atoulme
reviewed
Jun 29, 2024
| | Issues | [](https://github.com/open-telemetry/opentelemetry-collector-contrib/issues?q=is%3Aopen+is%3Aissue+label%3Aexporter%2Frabbitmq) [](https://github.com/open-telemetry/opentelemetry-collector-contrib/issues?q=is%3Aclosed+is%3Aissue+label%3Aexporter%2Frabbitmq) | | ||
| | [Code Owners](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#becoming-a-code-owner) | [@swar8080](https://www.github.com/swar8080), [@atoulme](https://www.github.com/atoulme) | | ||
|
|
||
| [development]: https://github.com/open-telemetry/opentelemetry-collector#development | ||
| [alpha]: https://github.com/open-telemetry/opentelemetry-collector#alpha | ||
| [contrib]: https://github.com/open-telemetry/opentelemetry-collector-releases/tree/main/distributions/otelcol-contrib |
There was a problem hiding this comment.
Remember to add it in opentelemetry-releases
atoulme
approved these changes
Jun 29, 2024
TylerHelmuth
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Promotes the RabbitMQ exporter to alpha
Testing:
Manual testing and integration tests implemented in a previous PR